No confirmation for failed search

Bug #675723 reported by Danielle Foré
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Postler
Fix Released
Low
Cris Dywan

Bug Description

When you do a search for something with no results, you get a blank page. It would be good to have some sort of confirmation that the search has indeed been completed, yet yielding no results. I've attached a screenshot of Google's no search results page as a reference.

Revision history for this message
Danielle Foré (danrabbit) wrote :
Allen Lowe (lallenlowe)
Changed in postler:
importance: Undecided → Low
status: New → Confirmed
Cris Dywan (kalikiana)
Changed in postler:
status: Confirmed → In Progress
assignee: nobody → Christian Dywan (kalikiana)
Revision history for this message
Cris Dywan (kalikiana) wrote :

I implemented a sort of error display which is now used in case of no search results or an account where fetching folders failed.

Changed in postler:
status: In Progress → Fix Committed
Revision history for this message
Sergio Spinatelli (spinatelli) wrote :

@ Christian:
If you search something and there are no hits,the message still isn't shown. I gave a look at the commit you've made and I may have figured out what the problem could be. At about line 747 of postler-messages.vala you've put:

if (location.has_prefix ("search:") && n_messages == 0) {
                display_error (_("No messages found"),
                    _("Check the spelling or try a different filter."));
                 return false;
            }

The AND should be replace by an OR (which in my case worked).
Hope I didn't say something stupid..=)

Cris Dywan (kalikiana)
Changed in postler:
status: Fix Committed → In Progress
Revision history for this message
Cris Dywan (kalikiana) wrote :

Your suggestion is not quite right, since it would show on empty folders as well. But you brought me to a better idea: to actually check if we had any filters.

Cris Dywan (kalikiana)
Changed in postler:
status: In Progress → Fix Committed
Cris Dywan (kalikiana)
Changed in postler:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.