New message notification and sound

Bug #671538 reported by Christian Dywan on 2010-11-05
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Postler
Fix Released
Low
Unassigned

Bug Description

When new messages arrive in any Inbox, Postler should show a notification and play a sound if sounds are enabled.

libnotify and libcanberra should be used respectively.

Daniel Fore (danrabbit) on 2010-11-05
Changed in postler:
status: New → Confirmed
Allen Lowe (lallenlowe) on 2010-11-05
Changed in postler:
importance: Undecided → Low
Bernd Prünster (jesusmccloud) wrote :

libnotify ftw!
icon is missing since i dont know the the name of the icon

Bernd Prünster (jesusmccloud) wrote :

forgot wscript

Daniel Fore (danrabbit) wrote :

The name of the icon is "internet-mail"

Bernd Prünster (jesusmccloud) wrote :

works on top of the other patches

Christian Dywan (kalikiana) wrote :

I committed the combination of these 3 patches, with some changes.

For "n message(s)" we want to use ngettext, which allows proper localisation even in languages with more than two plural forms like Arabic.

Please avoid unnecessary global or public variables, such as 'unread' and the notification object.

Please use spaces around operators and brackets, to keep code consistently readable.

Changed in postler:
assignee: nobody → Christian Dywan (kalikiana)
status: Confirmed → In Progress
Christian Dywan (kalikiana) wrote :

I implemented sound with libcanberra now. A sound theme needs to be installed to hear the sound, 'sound-themefreedesktop' is enough mind it only has 'message' but no specific 'message-new-mail'.

Christian Dywan (kalikiana) wrote :

The final step is to mark all new messages as unread, ie. move from /new to /cur folder, when opening a folder. So that notifications don't include messages the user is aware of.

Changed in postler:
assignee: Christian Dywan (kalikiana) → nobody
Changed in postler:
milestone: none → 0.1
Bernd Prünster (jesusmccloud) wrote :

moves unread messages

Christian Dywan (kalikiana) wrote :

Looks good. As discussed, I changed it from copy+delete to rename.

I also named the error 'error' rather than 'e', please try to use words as names where it makes sense.

Changed in postler:
status: In Progress → Fix Committed
Changed in postler:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers