documentation incomplete: Server.xact_think

[Gerrit Hohl]

In the file workloads/include/polymix-4-guts.pg the property xact_think of the Server class is used in line 19. But it isn't mentioned in the Reference Manual > PGL > Types page.
http://www.web-polygraph.org/docs/reference/pgl/types.html#type:docs/reference/pgl/types/Server

Server S = {
     kind = "PolyMix-4-srv";

     contents = [ cntImage: 65%, cntHTML: 15%, cntDownload: 0.5%, cntOther ];
     direct_access = [ cntHTML, cntDownload, cntOther ];

     xact_think = norm(2.5sec, 1sec);
     pconn_use_lmt = zipf(16);
     idle_pconn_tout = 15sec;
     abort_probe = 0.1%;

     addresses = serverAddrs(asPolyMix4, TheBench);
     http_versions = [ "1.0" ]; // newer agents use HTTP/1.1 by default
};

As you programmed the web polygraph in C++ I assume that you maybe used some kind of object inheritance. Maybe the Agent class - which has a xact_think property - is the superclass of the Server class.

http://www.web-polygraph.org/docs/reference/pgl/types.html#type:docs/reference/pgl/types/Agent

If that is the case, the documentation also lacks the inheritance dependencies.

[Gerrit Hohl (g-hohl)]

Same goes for Server.pconn_use_lmt

[Gerrit Hohl (g-hohl)]

And also for Server.abort_prob

[Gerrit Hohl (g-hohl)]

Seems like Robot also is a subclass of Agent.

[Dmitry Kurochkin (dmitry.kurochkin)]

Yes, Robot and Server are inherited from Agent. So these fields are documented. But the class hierarchy documentation is missing.

[Alex Rousskov (rousskov)]

Actually, the fact that Server and Robot are derived from Agent is documented as the first five words of the Server and Robot documentation: "Derived from the Agent type, ..."

The Agent documentation states the same thing, with even more detail: "Agent is a base type for PGL robots, servers, and proxies. In other words, agents have properties common to those three types."

Granted, we can show and explain the dependency better.