Listened "tick" inconsistent

[Alan Pope 🍺🐧🐱 🦄]

I have listened to a few shows. Some have a tick to indicate they're listened to, others do not.
Seems to also lose the tick if I delete a podcast I have already listened to.

[Nekhelesh Ramananthan (nik90)]

The listened tick is marked automatically when the user has listened to atleast 70% of that episode (based on the duration). I am not entirely sure why this might be inconsistent as it makes sense. There is a bug report requesting for providing a way to mark episodes as listened manually in bug 1435549.

Just to be clear, does the tick inconsistency happen when you delete a downloaded episode? Or when deleting a podcast (along with its episodes) as a whole? When you delete a podcast (along with all its episodes) it is removed from the database. So when you re-add that podcast, podbird starts from scratch.

[Denis Štogl (destogl)]

I can confirm this on my BQ phone.

Sometimes are podcast marked as listened sometimes not. Until now I didn't get any pattern it seams random. For me this happens when I listen/after listening the episode. When the episode is deleted the episode stays listened as it should be.

[Michal Predotka (mpredotka)]

Same situation in the new version. I don't know if it's because I clicked fast forward few times to skip the adverts. But for sure I listened to more than 70% of the show.

[Nekhelesh Ramananthan (nik90)]

hmm the code that marks an episode listened automatically is,

if (position >= duration - 120) {
     tx.executeSql("UPDATE Episode SET listened = 1 WHERE guid=?", [currentGuid]);
}

I think the issue is the if logic (position >= duration - 120) that we have here. I will see if I can sneak a fix to this in v0.6 itself.

[Nekhelesh Ramananthan (nik90)]

On further investigation it turns out that the code which checks if position >= duration -120 doesn't get run if podbird is in the background. So when the user returns to podbird when the podcast has finished playing, the position is 0 that code path is never executed leading to inconsistent ticks marks. I am not sure if this is fixable and we may have to remove the automatic tick marking feature.

[Alexander Dobetsberger (masternoob)]

Please add an option to only mark episodes as listened that are 100% listened.
It really depends on the podcasts you listen to if you want to mark them as listened with 70%.
Should i create a new bug for this?