Improve documentation on Controller
Bug #551594 reported by
Rob Dawson
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| play framework | Status tracked in 1.0 | |||||
| 1.0 |
Fix Released
|
Medium
|
Nicolas Leroux | |||
| 1.1 |
Fix Committed
|
Undecided
|
Unassigned | |||
Bug Description
The use of static fields for the request, response and other transient/http request fields in the Controller is somewhat scary to see, it is only after digging into the bowels of play, and noticing the use of the ControllersEnhancer to ensure that usages of the static fields are replaced by ThreadLocals that the fears are relieved. It would be great to save some stress for experienced people looking at play, and add javadoc which makes them comfortable.
I've attached a patch which attempts to add this information, and hopefully shows the kind of information that would have stopped me from loosing sleep :).
Revision history for this message
| Rob Dawson (robert-rojotek) wrote | #1 |
Revision history for this message
| Nicolas Leroux (nicolas-lunatech) wrote | #2 |
To post a comment you must log in.
Added, thanks