NPE when calling renderTemplate 2 times

[Nicolas Leroux]

The PDF module use the renderTemplate method to render the template prior to transform it into a PDF that it then save on disk. Note that it can really well be the same problem with rendering one or two emails.

Once this is done I am rendering an HTML template so the user can see some HTML to download the file for example.

However, it seems that the template compiler has a state. I have a NPE. In order to fix the NPE, I had to remove the out argument from the renderArgs.data:

renderArgs.data.remove("out");

In the code that renders the template (Template.render), I can indeed see:

if (!args.containsKey("out")) {
            applyLayouts = true;
            layout.set(null);
            writer = new StringWriter();
            binding.setProperty("out", new PrintWriter(writer));
            currentTemplate.set(this);
        }

It seems that out is still there but already closed I think. Removing the

if (!args.containsKey("out"))

solves the problem and the tests pass. However, I was wondering for what reason the if line was there.

[psartini (piero-sartini)]

Maybe this is somehow related to #554762 ?