Creating war fails in 1.1-unstable because of a missing dist_dir

Bug #524335 reported by Tristan Wehrmaker
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
play framework
Status tracked in 1.0
1.0
Fix Released
Undecided
Erwan Loisant
1.1
Fix Committed
Undecided
Erwan Loisant

Bug Description

The war creation in 1.1-unstable with:

play war --o=../new --zip

fails, with this error:

Traceback (most recent call last):
  File "/Users/tris/Developer/play/play", line 899, in <module>
    if dirpath == dist_dir:
NameError: name 'dist_dir' is not defined

In line 899 of "play" the name dist_dir is used, which is not defined. This was added in revision 774 of 1.1-unstable.

Erwan Loisant (eloisant)
Changed in play:
assignee: nobody → Erwan Loisant (eloisant)
status: New → Fix Committed
Revision history for this message
Rob Dawson (robert-rojotek) wrote :

This bug occurs in 1.0 unstable as well.

In 1.0 the war_zip_path guards at the end of the file don't seem to be required, as there were a series of checks earlier in processing to protect against this problem. I've attached a patch which includes a fix to the 1.0 branch (this may be the wrong way to go about doing this).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.