downloading big files is broken

[bran]

with the latest nightly in the 1.1 branch, downloading big files is broken.

windows 7, jdk 1.6.20, play! 1.1-unstable-r982

Serving files in the public folder of applications is unreliable. Any files bigger than 80+K are truncated. Start to display this behavior when file sizes approach 80K.

[dirk (australiandeveloper)]

I'm seeing the same behaviour on a mac with firefox and safari.

[dirk (australiandeveloper)]

Works for me now, thanks for the quick fix!

[dirk (australiandeveloper)]

Hmm actually after doing some more testing it seems it didn't actually work.
Still having the issue with both firefox and safari on my mac, at revision 1.1-unstable-r988

[Nicolas Leroux (nicolas-lunatech)]

Hmm I cannot reproduce it anymore... Do you do anything special?

[bran (bing-ran)]

I just did a merge from the master and "ant clean" and "ant". The problem was still there. For a file of 85K it worked sometimes and failed otherwise.

[dirk (australiandeveloper)]

I'm also still seeing the problem on mac firefox/safari

I had a look at the diff, and if I understand right, the piece of code that you changed (line 332) is only called if a plugin is rendering a static file. Do you need to make the same change for static files that are rendered by normal Controllers? If so, you'd need to change line 671:

http://bazaar.launchpad.net/~play-developers/play/1.1-unstable/annotate/988/framework/src/play/server/PlayHandler.java#L670

[Nicolas Leroux (nicolas-lunatech)]

Yes you are quite right, that is the mistake :) Thank you so much!!

[Nicolas Leroux (nicolas-lunatech)]

Can you check again? Thanks

[dirk (australiandeveloper)]

Yes it works for me now :)

[bran (bing-ran)]

looks good here too. Thanks a lot!

[Nicolas Leroux (nicolas-lunatech)]

No thanks to both of you for the bug report!