feature request: the play install {module} also adds the proper entry in the application.conf

[bran]

Current it requires a user to manually add the reference to a module in the application.conf. This can be done by the installation process and developers experience will be better.

[Guillaume Bort (guillaume-bort)]

You can already use:

play new myApplication --with japid

On Sat, Feb 13, 2010 at 9:00 AM, bran <email address hidden> wrote:
> Public bug reported:
>
> Current it requires a user to manually add  the reference to a module in
> the application.conf. This can be done by the installation process and
> developers experience will be better.
>
> ** Affects: play
>     Importance: Undecided
>         Status: New
>
> --
> feature request: the play install {module} also adds the proper entry in the application.conf
> https://bugs.launchpad.net/bugs/521296
> You received this bug notification because you are subscribed to play
> framework.
>

[bran (bing-ran)]

Good to know that. But I was talking more about existing applications installing new modules.

[Guillaume Bort (guillaume-bort)]

Yes of course.

On Sat, Feb 13, 2010 at 6:35 PM, bran <email address hidden> wrote:
> Good to know that. But I was talking more about existing applications
> installing new modules.
>
> --
> feature request: the play install {module} also adds the proper entry in the application.conf
> https://bugs.launchpad.net/bugs/521296
> You received this bug notification because you are subscribed to play
> framework.
>

[bran (bing-ran)]

Can you tell me what command to use to achieve that? play install {module} won't do that, or does it?

[Guillaume Bort (guillaume-bort)]

We need to create a new command.

On 13 févr. 2010, at 19:35, bran <email address hidden> wrote:

> Can you tell me what command to use to achieve that? play install
> {module} won't do that, or does it?
>
> --
> feature request: the play install {module} also adds the proper
> entry in the application.conf
> https://bugs.launchpad.net/bugs/521296
> You received this bug notification because you are subscribed to play
> framework.

[bran (bing-ran)]

Good. I'd like to ask to add a hook for the plugin to do some work at installation time, something like onInstallation(), which is called when "play intsall {module}" issued.

[Guillaume Bort (guillaume-bort)]

It will probably be a python hook.

On Sun, Feb 14, 2010 at 5:56 AM, bran <email address hidden> wrote:
> Good. I'd like to ask to add a hook for the plugin to do some work at
> installation time, something like onInstallation(), which is called when
> "play intsall {module}" issued.
>
> --
> feature request: the play install {module} also adds the proper entry in the application.conf
> https://bugs.launchpad.net/bugs/521296
> You received this bug notification because you are subscribed to play
> framework.
>

[Erwan Loisant (eloisant)]

Fixed with:
play add --module=sass

Then it's up to the module to use before() and after() to do stuff after a module is installed. It doesn't reuse the same code as new on purpose, because some modules have pretty destructive actions on a new application (like Scala that destroys Application.java).