Underscores in some menu items not shown

Bug #1662968 reported by Peter Feichtinger on 2017-02-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Plank
Low
Peter Feichtinger

Bug Description

Because all menu items for the dock item context menu are created with mnemonics enabled, underscores will not be shown.
This is a problem for window titles and for file names in the Trash docklet menu.
For folder items there's a workaround in the code (doubling all underscores).

The attached patch fixes the problem by introducing new factory methods for literal menu items (which should not use mnemonics).

Plank version 0.11.3 running on Arch Linux with xfwm4.

Related branches

Peter Feichtinger (shippo) wrote :
Rico Tzschichholz (ricotz) wrote :

Overall this seems like a proper solution (without breaking ABI).
Although pixbufs retrieved with DrawingService.load_icon() should not be treated with ar_scale() again.

Peter Feichtinger (shippo) wrote :

Since DrawingService.load_icon() presumably loads the pixbufs with the right size, they wouldn't be resized again.

Rico Tzschichholz (ricotz) wrote :

Either width *or* height are guarantied to match, but you can not rely on both. Although the checks in ar_scale() are sufficient to bail early in this case. Although it would be nice to avoid the calls of icon_size_lookup() and ar_scale() as it was before.

Peter Feichtinger (shippo) wrote :

I don't like the duplicated code, but you're right.
New patch attached.

Rico Tzschichholz (ricotz) wrote :

Thanks, pushed as r1587 with some minor additions.

Changed in plank:
assignee: nobody → Peter Feichtinger (shippo)
importance: Undecided → Low
status: New → Fix Committed
milestone: none → 0.12.0
Changed in plank:
milestone: 0.12.0 → 0.11.4
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers