Freeze caused by LauncherAPI update requests of Audex

Bug #1514201 reported by Makar on 2015-11-08
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Plank
Medium
Rico Tzschichholz

Bug Description

Hangs when I start to import audio tracks through the program Audex
https://userbase.kde.org/Audex
The dock is to be animation import process audio tracks. Dock hangs.

Plank 0.10.1
elementary OS 0.3.1 Freya (64-bit)
NVIDIA Driver Version: 355.11

Related branches

Makar (makaron) wrote :

Audex
version 0.78

Rico Tzschichholz (ricotz) wrote :

I assume Audex is implementing the LauncherEntry support to provide status information to be shown in plank. Here it looks like it is implemented horribly while updating the value way too frequently.

So I would mainly call this a bug of Audex. I checked this a bit and to reach this cpu-usage here I need to trigger an update like every 8ms or less. In this case 1000ms aka 1sec would suffice and this is still quite frequently.

On the plank-side there is still some room for optimizations though.

Changed in plank:
status: New → Incomplete
Makar (makaron) wrote :

Can you teach Plank ignore such conduct third-party software?

Makar (makaron) wrote :

For example, if a third-party application is behaving uncivilized not to display information to the dock to prevent bridging

summary: - Hangs when I start to import audio tracks through the program Audex
+ Freeze caused by LauncherAPI update requests of Audex
Changed in plank:
status: Incomplete → Confirmed
importance: Undecided → Medium
Changed in plank:
assignee: nobody → Rico Tzschichholz (ricotz)
status: Confirmed → In Progress
milestone: none → 0.11.0
Rico Tzschichholz (ricotz) wrote :

Would be nice if someone hit by this problem could test the attached branch.

Am 07.01.2016 um 16:59 schrieb Rico Tzschichholz:
> Would be nice if someone hit by this problem could test the attached
> branch.
>

I tried it but I am getting a compile error:

make[2]: Entering directory '/data/src/tmp/plank/lib'
  VALAC libplank_internal_la_vala.stamp DBusManager.vala DockController.vala DockPreferences.vala DockRenderer.vala DragManager.vala HideManager.vala PositionManager.vala DBus/Client.vala DBus/Interfaces.vala Docklets/Docklet.vala Docklets/DockletItem.vala Docklets/DockletManager.vala Drawing/Color.vala Drawing/DrawingService.vala Drawing/DockTheme.vala Drawing/Easing.vala Drawing/Renderer.vala Drawing/Surface.vala Drawing/SurfaceCache.vala Drawing/Theme.vala Factories/AbstractMain.vala Factories/Factory.vala Factories/ItemFactory.vala Items/ApplicationDockItem.vala Items/ApplicationDockItemProvider.vala Items/DefaultApplicationDockItemProvider.vala Items/DockContainer.vala Items/DockItem.vala Items/DockItemProvider.vala Items/DockItemPreferences.vala Items/DockElement.vala Items/Enums.vala Items/FileDockItem.vala Items/PlaceholderDockItem.vala Items/PlankDockItem.vala Items/TransientDockItem.vala Services/Environment.vala Services/Logger.vala Services/Paths.vala Services/Preference
 s
.vala Services/Settings.vala Services/System.vala Services/Worker.vala Widgets/CompositedWindow.vala Widgets/DockWindow.vala Widgets/HoverWindow.vala Widgets/PoofWindow.vala Widgets/PreferencesWindow.vala Widgets/TitledSeparatorMenuItem.vala Version.vala Makefile
Items/ApplicationDockItem.vala:835.15-835.25: error: syntax error, expected `;'
  public void unity_reset ()
              ^^^^^^^^^^^
Compilation failed: 1 error(s), 0 warning(s)
Makefile:1665: recipe for target 'libplank_la_vala.stamp' failed
make[2]: *** [libplank_la_vala.stamp] Error 1
make[2]: Leaving directory '/data/src/tmp/plank/lib'
Makefile:512: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/data/src/tmp/plank'
Makefile:442: recipe for target 'all' failed
make: *** [all] Error 2

I get the same error also for the master branch.

Matthias

Rico Tzschichholz (ricotz) wrote :

Sorry, this is a fallout while building without dbusmenu-glib support. Please update and retry again.

mbod (matthias-bodenbinder) wrote :

Am 07.01.2016 um 19:04 schrieb Rico Tzschichholz:
> Sorry, this is a fallout while building without dbusmenu-glib support.
> Please update and retry again.
>

I tested it and it fixes the issue for me. No more plank freezes with audex.

Matthias

Rico Tzschichholz (ricotz) wrote :

Thanks for testing!

Fixed in r1480

Changed in plank:
status: In Progress → Fix Committed
Changed in plank:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers