Plank

Make theme chooseable through a settings-option

Bug #1062178 reported by Rico Tzschichholz
14
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Plank
Fix Released
Wishlist
Rico Tzschichholz

Bug Description

Add the theme=NAME option to DockPreferences to make the theme easily selectable.
NAME would be the folder-name located in plank's system- or user-themes-folder (/usr/share/plank/themes/*,~/.local/share/plank/themes/*). This folder will contain the dock.theme/hover.theme files as we know them.

Related branches

lp:~docky-core/plank/themes
Robert Dyer (community): Needs Fixing
Diff: 629 lines (+304/-10)
11 files modified
data/themes/Default/dock.theme (+54/-0)
data/themes/Default/hover.theme (+17/-0)
lib/DockPreferences.vala (+11/-0)
lib/DockRenderer.vala (+22/-4)
lib/Drawing/DockTheme.vala (+5/-0)
lib/Drawing/HoverTheme.vala (+5/-0)
lib/Drawing/Theme.vala (+113/-2)
lib/Services/Paths.vala (+12/-0)
lib/Services/Preferences.vala (+38/-1)
lib/Widgets/HoverWindow.vala (+18/-3)
lib/libplank.symbols (+9/-0)
Robert Dyer (psybers)
Changed in plank:
importance: Undecided → Wishlist
Rico Tzschichholz (ricotz)
Changed in plank:
status: New → In Progress
assignee: nobody → Rico Tzschichholz (ricotz)
Revision history for this message
Robert Dyer (psybers) wrote :

Why. I don't see a need for this.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

To have quite normal way to select a theme out of multiple ones which are user-specific or installed system-wide.

Revision history for this message
Robert Dyer (psybers) wrote :

That is already possible, and just as easy to do currently as your proposed change.

Revision history for this message
Rico Tzschichholz (ricotz) wrote :

I wouldn't call using "ln -s ..." easy for average users and this can go wrong too. This way we are looking in well defined locations and handle the fallback possibilities. Changing a value in a keyfile is therefore a cleaner way to switch themes.

This change is also a step closer to transitioning DockPreferences to GSettings which opens the possibilities to use overrides for 3rd parties.

Rico Tzschichholz (ricotz)
Changed in plank:
status: In Progress → Fix Committed
Rico Tzschichholz (ricotz)
Changed in plank:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.