plainbox will complain about id field is missing for jobs in resource.pxu with os-id: debian

Bug #1443228 reported by Po-Hsu Lin on 2015-04-13
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PlainBox (Toolkit)
High
Zygmunt Krynicki

Bug Description

These 11 jobs with "os-id: debian" in the plainbox-provider-resource-generic/jobs/resource.pxu will cause plainbox complain about the id field is missing.

Error message:
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
ERROR plainbox.ctrl: Ignoring invalid generated job None: Problem with field id: missing
WARNING plainbox.ctrl: Automatically breaking via-cycle: Resources -> Resources

Test steps:
1. branch the latest checkbox (3681), run checkbox-cli
2. Select client-cert whitelist only

These error messages will came up during the resource job execution stage.

plainbox-provider-resource-generic/jobs/resource.pxu:
# This is for all the Python scripts
unit: packaging meta-data
os-id: debian
Depends: python3 (>= 3.2)

# This is for bin/efi_resource, bin/cpuinfo_resource, bin/gconf_resource,
# bin/gconf_resource, bin/meminfo_resource, bin/udev_resource
# and bin/xinput_resource
unit: packaging meta-data
os-id: debian
Depends: python3-checkbox-support (>= 0.2)

# This is for bin/display_resource
unit: packaging meta-data
os-id: debian
# NOTE: This is not a hard dependency so that
# plainbox-provider-resource-generic has minimalistic dependencies.
Suggests: x11-server-utils

# This is for bin/dmi_resource
unit: packaging meta-data
os-id: debian
Depends: dmidecode

# This is for bin/dpkg_resource
unit: packaging meta-data
os-id: debian
Depends: dpkg (>= 1.13),

# This is for bin/gconf_resource
unit: packaging meta-data
os-id: debian
# NOTE: This is not a hard dependency so that
# plainbox-provider-resource-generic has minimalistic dependencies.
Suggests: gconf2

# This is for bin/lsb_resource
unit: packaging meta-data
os-id: debian
Depends: lsb-release

# This is for bin/mobilebroadband_resource
unit: packaging meta-data
os-id: debian
Depends: network-manager

# This is for bin/optical_resource and bin/udev_resource
unit: packaging meta-data
os-id: debian
Depends: udev

# This is for bin/xinput_resource
unit: packaging meta-data
os-id: debian
# NOTE: This is not a hard dependency so that
# plainbox-provider-resource-generic has minimalistic dependencies.
Suggests: xinput

# This is for 'usb'
unit: packaging meta-data
os-id: debian
Depends: usbutils

Related branches

Zygmunt Krynicki (zyga) wrote :

None of those units are jobs. I wonder what's going on there though.

Zygmunt Krynicki (zyga) wrote :

Ah, I understand now. It is assumed that local jobs can only create jobs. That's obviously false. I recall the session controller uses a (deprecated) add_job() method for this hence the weird error.

Changed in plainbox:
status: New → Triaged
importance: Undecided → High
assignee: nobody → Zygmunt Krynicki (zyga)
milestone: none → 0.21
Zygmunt Krynicki (zyga) wrote :

I'll back-port this to the 0.21c2 once we fix it in trunk. It's pretty annoying to see all the time and it should be easy to do.

Zygmunt Krynicki (zyga) on 2015-04-13
Changed in plainbox:
status: Triaged → In Progress
Zygmunt Krynicki (zyga) on 2015-04-15
Changed in plainbox:
status: In Progress → Fix Committed
Changed in plainbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers