plainbox silently ignores dead entries in whitelists

Bug #1262251 reported by Zygmunt Krynicki
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
PlainBox (Toolkit)
Fix Released
High
Unassigned

Bug Description

This is a composite bug but we basically need all the support required for plainbox to detect dead (or broken, e.g. typos) entries in whitelists. We want to have a way to ensure that our whitelists are correct and preferrably do that earlier than users telling us some tests are being skipped or checkbox-old choking on stale entries.

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

We should modify select_jobs() to return annotated qualifier list. It might be challenging to map that back to the source representation but I'm sure we can figure something out. The information should be displayed by `manage.py validate`. It should not be something that operators running the tests should be warned about every time they run pre-existing tests.

Changed in checkbox:
milestone: none → plainbox-0.6
importance: Undecided → Medium
status: New → Triaged
Zygmunt Krynicki (zyga)
Changed in plainbox:
milestone: none → 0.6
importance: Undecided → Medium
status: New → Triaged
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I think this should be handled by the (inexisting) whitelist validator. On command line we can probably provider similar hints for each of the -w / -i options used

Changed in checkbox:
milestone: plainbox-0.6 → none
Zygmunt Krynicki (zyga)
Changed in plainbox:
importance: Medium → High
Zygmunt Krynicki (zyga)
no longer affects: checkbox
Zygmunt Krynicki (zyga)
tags: removed: plainbox
Changed in plainbox:
milestone: 0.6 → 0.7
Changed in plainbox:
milestone: 0.7 → 0.9
Changed in plainbox:
milestone: 0.9 → 0.11
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Re: [Bug 1262251] Re: plainbox silently ignores dead entries in whitelists

Can we try => future instead the next time. As before, we're not
working on the majority of bugs each two weeks. Let's schedule stuff
to future and re-schedule only those that have a chance of landing.

On Mon, Jul 28, 2014 at 5:30 PM, Sylvain Pineau
<email address hidden> wrote:
> ** Changed in: plainbox
> Milestone: 0.9 => 0.11
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1262251
>
> Title:
> plainbox silently ignores dead entries in whitelists
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/plainbox/+bug/1262251/+subscriptions

Daniel Manrique (roadmr)
Changed in plainbox:
milestone: 0.11 → future
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I think this is much, much better now. New style validation captures this issue pretty well. The remaining things that could be fixed to get this better are related to handling validation of command line arguments like 'run -i' but I don't think we need anything more on the whitelist front itself.

Oh, we obviously need to enable the new style validation by default everywhere and get rid of the old code.

Changed in plainbox:
assignee: nobody → Zygmunt Krynicki (zkrynicki)
status: Triaged → In Progress
Zygmunt Krynicki (zyga)
Changed in plainbox:
assignee: Zygmunt Krynicki (zyga) → nobody
Zygmunt Krynicki (zyga)
Changed in plainbox:
status: In Progress → Triaged
Changed in plainbox:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.