Modify dmidecode jobs to use new dmi.supported resource
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
Medium
|
Unassigned |
Bug Description
From this MR
jobs that depend on dmi can now simply check dmi.supported == 'True' rather than a possibly changing and outdated cpuinfo.platform check for specific architectures.
To this end, any jobs (in plainbox-
Ultimately, if DMI is supported, but using it fails, or casues a failure or crash, that's a bug that should be caught and handled.
so the necessary change would be changing something like this:
requires:
package.name == 'dmidecode' or executable.name == 'dmidecode'
cpuinfo.platform in ("i386", "x86_64")
to
requires:
package.name == 'dmidecode' or executable.name == 'dmidecode'
dmi.supported == 'True'
And it may be even OK to drop the package requirement since dmidecode is part of the default packages on every install that supports the package (e.g. no packages built for Power and Z).
Related branches
- Maciej Kisielewski (community): Approve
-
Diff: 55 lines (+8/-4)2 files modifiedjobs/miscellanea.txt.in (+7/-3)
jobs/submission.txt.in (+1/-1)
Changed in plainbox-provider-checkbox: | |
importance: | Undecided → Medium |
Changed in plainbox-provider-resource: | |
importance: | Undecided → Medium |
Changed in plainbox-provider-checkbox: | |
status: | New → Confirmed |
Changed in plainbox-provider-resource: | |
status: | New → Triaged |
Changed in plainbox-provider-checkbox: | |
status: | Confirmed → Triaged |
milestone: | none → future |
Changed in plainbox-provider-resource: | |
milestone: | none → future |
no longer affects: | plainbox-provider-resource |
Changed in plainbox-provider-checkbox: | |
milestone: | future → 0.40.0 |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
Paul's MR that handles the resource: /code.launchpad .net/~pwlars/ plainbox- provider- resource/ +git/plainbox- provider- resource/ +merge/ 328045
https:/
Now jobs that previously had kludgey ways of not running on non-dmi systems should be modified to use:
dmi_present.state == 'supported'
Such as this modified version of the dmi resource job in plainbox- provider- resource
59 id: dmi
60 estimated_duration: 0.59
61 plugin: resource
62 requires:
63 - cpuinfo.platform in ("i386", "x86_64")
64 + dmi_present.state == 'supported'
65 user: root
66 command: dmi_resource
67 _summary: Collect information about hardware devices (DMI)