"audio/valid-sof-firmware-sig" Should not be tested with the machine does not use Intel DMIC to PCH or Soundwire feature

Bug #1956293 reported by Kent Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Expired
Critical
Jonathan Cave

Bug Description

Not all machines use Intel DMIC to PCH or Soundwire Feature. When this test is run on those machines, it always fail. The test case needs to add more resource check to make sure it only run on the machine which uses DMIC or Soundwire.

plugin: shell
category_id: com.canonical.plainbox::audio
id: audio/valid-sof-firmware-sig
requires:
 device.category == 'AUDIO'
 package.name == 'linux-firmware'
command:
 fail=0
 for fw in /lib/firmware/intel/sof/sof-*.ri;
 do
     # shellcheck disable=SC2016
     if xxd "${fw}" | grep -q '$CPD'; then
         if ! sof_ri_info.py --valid "${fw}";
         then
             fail=1
         fi
     fi
 done
 exit $fail
_description: Valid sof firmware signature

Tags: cbox-5
Kent Lin (kent-jclin)
Changed in plainbox-provider-checkbox:
importance: Undecided → Critical
assignee: nobody → Jonathan Cave (jocave)
Kent Lin (kent-jclin)
summary: "audio/valid-sof-firmware-sig" Should not be tested with the machine
- does not use Intel DMIC or Soundwire feature
+ does not use Intel DMIC to PCH or Soundwire feature
description: updated
Revision history for this message
Rex Tsai (chihchun) wrote :

This test job does not depends on the hardware features of DMIC, SoF, but simply checking if the firmware shipped with the image is signed with the correct key from Intel.

Revision history for this message
Rex Tsai (chihchun) wrote :

The issue is missing production key for ehl[1] and ADL[2], which are all landed as well.

[1] Add JSL, TGL_H and TGL_LP production key - https://git.launchpad.net/plainbox-provider-checkbox/commit/?id=611bc1f9e888aec621e6c88a0fcab2c7e3d9348f
[2] Add ADL production key - https://git.launchpad.net/plainbox-provider-checkbox/commit/bin/sof_ri_info.py?id=da7353fdafacd7d5aefa9bb622a962df53aeeead

Matias Piipari (mz2)
tags: added: cbox-5
Revision history for this message
Maksim Beliaev (beliaev-maksim) wrote :

Bug was migrated to GitHub: https://github.com/canonical/checkbox/issues/48.
Bug is no more monitored here.

Changed in plainbox-provider-checkbox:
status: New → Expired
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.