Two wwan cases result not correct

Bug #1937257 reported by Rick Wu
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
High
StanleyHuang

Bug Description

[Summary]
There are two wwan auto test cases result not correct. Seems the case should be fail, but checkbox marked as pass.

1.wwan/check-sim-present-{manufacturer}-{model}-{hw_id}-auto
  This case will pass even SIM card not been inserted and sim path is "/".
===== busctl introspect org.freedesktop.ModemManager1 /org/freedesktop/ModemManager1/Modem/0 =====
...
.Sim property o "/" emits-change
...

2.wwan/gsm-connection-{manufacturer}-{model}-{hw_id}-auto
  This case will pass even gsm connection not been established.
 ===== log for output =====
  Connection 'GSMCONN' (6467a58f-ebe7-4643-90ad-721f53e4e5ce) successfully added.
  Error: Device for nexthop is not up.
  Connection 'GSMCONN' (6467a58f-ebe7-4643-90ad-721f53e4e5ce) successfully deleted.

Related branches

Rick Wu (rickwu4444)
Changed in plainbox-provider-checkbox:
assignee: nobody → Jonathan Cave (jocave)
Revision history for this message
Jonathan Cave (jocave) wrote :

@Rick thanks for the bug report - can you provide some information about how to reproduce the bugs? which devices does this happen on and which images?

Revision history for this message
StanleyHuang (stanley31) wrote :

@Jonathan,

I did some testing with Rick yesterday. For both issue, we have to raise sys.exit(1) rather than return 1. So the checkbox could not get the status code of last command. Thanks.

I will send an MR latter. :)

Revision history for this message
Jonathan Cave (jocave) wrote :

A fix is obviously welcomed, but please add the information requested to the bug. It's important we understand how badly this may have effected testing.

Jonathan Cave (jocave)
Changed in plainbox-provider-checkbox:
status: Confirmed → Fix Committed
assignee: Jonathan Cave (jocave) → StanleyHuang (stanley31)
milestone: none → 0.60.0
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
Matias Piipari (mz2)
tags: added: cbox-12
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.