Include UEFI info in the submission.json
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
High
|
Sylvain Pineau |
Bug Description
On certification.
Here is background for what the xml reports had:
Back when we used xml reports, checkbox_support had a parser that turned the xml into json for us, and we'd extract bios information from the "set-devices" element. C3 would check for the existence of devices with "EFI" or "BIOS" as a category.
I am not recommending we go back to those days. What I would prefer is an element that is just for bios information that includes whether it is UEFI or Legacy. We already do get an element with bios information in raw-devices-dmi. Maybe the UEFI bit could go there. Or, instead of flags we could perhaps add the characteristics from teh dmi data as a list.
Anyway, for reference, this an example of the part of the device set that the old checkbox_support generated from the old xml submission:
[
{
"category": "BIOS",
"subproduct
"product": "F.40",
"vendor": "Insyde",
"product_id": null,
"bus": "dmi",
"path": "/devices/
"vendor_id": null,
"driver": null,
"subvendor_id": null
},
{
"category": "EFI",
"subproduct
"product": "/var/log/
"vendor": "INSYDE Corp.",
"product_id": null,
"bus": "dmi",
"path": "/sys/class/
"vendor_id": null,
"driver": null,
"subvendor_id": null
},
{
"category": "EFI",
"subproduct
"product": "/var/log/
"vendor": "INSYDE Corp.",
"product_id": null,
"bus": "dmi",
"path": "/sys/class/
"vendor_id": null,
"driver": null,
"subvendor_id": null
}
]
I do not know how the entries in the xml got populated.
Related branches
- Sylvain Pineau (community): Approve
- Devices Certification Bot: Needs Fixing
- Jonathan Cave (community): Approve
-
Diff: 16 lines (+3/-1)1 file modifiedunits/submission/jobs.pxu (+3/-1)
Changed in checkbox-support: | |
importance: | Undecided → Medium |
Changed in checkbox-support: | |
status: | New → In Progress |
assignee: | nobody → Maciej Kisielewski (kissiel) |
importance: | Medium → High |
Changed in checkbox-support: | |
status: | In Progress → New |
assignee: | Maciej Kisielewski (kissiel) → nobody |
Changed in checkbox-support: | |
assignee: | nobody → Sylvain Pineau (sylvain-pineau) |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |
Since we get bios info in raw-devices-dmi (no where else, right?) could
Could the device dict about bios have an element with the UEFI bit?
Or, instead of a flag we could perhaps add the characteristics from the dmi data as a list - on the c3 side we'd check the list to see if UEFI is a member.
We still don't capture whether something is UEFI right now.