network test should only attempt targets that match NICs network
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Checkbox Provider - Base |
Fix Released
|
Medium
|
Rod Smith |
Bug Description
The way the network test currently works is that a user can supply any number of targets on any number of subnets and the network test will simply cycle through them over and over until either it times out or it finds one that works.
This can waste a lot of test time.
The network script should be modified to only test (initial ping and the iperf tests) when a target is on the NIC's network.
So, if the NIC is 192.168.0.1/24, the script should only react to targets on 192.168.0.0/24 and ignore targets on 10.0.0.0/24.
This will still preserve the ability to pass multiple targets on multiple subnets and allow configs that have different nics on different subnets. It will simply save some wasted time by not bothering to ping targets it has no business pinging in the first place.
Related branches
- Jeff Lane : Approve
-
Diff: 146 lines (+51/-25)1 file modifiedbin/network.py (+51/-25)
Changed in plainbox-provider-checkbox: | |
importance: | Undecided → Wishlist |
Changed in plainbox-provider-checkbox: | |
status: | New → Won't Fix |
Changed in plainbox-provider-checkbox: | |
status: | Won't Fix → New |
Changed in plainbox-provider-checkbox: | |
status: | New → In Progress |
assignee: | nobody → Rod Smith (rodsmith) |
importance: | Wishlist → Medium |
Changed in plainbox-provider-checkbox: | |
status: | In Progress → Fix Committed |
Changed in plainbox-provider-checkbox: | |
status: | Fix Committed → Fix Released |