checkbox lacks of net-tools dependency on 17.04

[Taihsiang Ho]

I ran SRU test by checkbox daily build and plainbox-provider-sru. Many network related test failed because it lacks of arp. For example:

networking/gateway_ping

Traceback (most recent call last):
  File "/tmp/nest-3ht7hfyx.08f1fd37f231e56f780ec9a033c7654ddc259d83db47afae8a485b26d9eefbc7/gateway_ping_test", line 286, in <module>
    sys.exit(main(sys.argv[1:]))
  File "/tmp/nest-3ht7hfyx.08f1fd37f231e56f780ec9a033c7654ddc259d83db47afae8a485b26d9eefbc7/gateway_ping_test", line 257, in main
    interface=args.interface, verbose=args.verbose, default=args.host)
  File "/tmp/nest-3ht7hfyx.08f1fd37f231e56f780ec9a033c7654ddc259d83db47afae8a485b26d9eefbc7/gateway_ping_test", line 140, in get_host_to_ping
    known_ips = subprocess.check_output(["arp", "-a", "-n"])
  File "/usr/lib/python3.5/subprocess.py", line 316, in check_output
    **kwargs).stdout
  File "/usr/lib/python3.5/subprocess.py", line 383, in run
    with Popen(*popenargs, **kwargs) as process:
  File "/usr/lib/python3.5/subprocess.py", line 676, in __init__
    restore_signals, start_new_session)
  File "/usr/lib/python3.5/subprocess.py", line 1282, in _execute_child
    raise child_exception_type(errno_num, err_msg)
FileNotFoundError: [Errno 2] No such file or directory: 'arp'

[Sylvain Pineau (sylvain-pineau)]

@Tai,

To fix this bug, the best way to add the missing dep is to add a packaging meta data unit [1] to the job pxu file. Doing so avoid the need to touch the debian/control file in the packaging repo.

The file to update is https://git.launchpad.net/plainbox-provider-checkbox/tree/jobs/ethernet.txt.in

Add the following lines (top of the file):

unit: packaging meta-data
os-id: debian
Depends: net-tools

[1] http://checkbox.readthedocs.io/projects/plainbox/en/latest/manpages/plainbox-packaging-meta-data-units.html?highlight=packaging