graphics/xorg-version will pass on a system without X

Bug #1570373 reported by Po-Hsu Lin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Checkbox Provider - Base
Fix Released
Medium
Po-Hsu Lin

Bug Description

This issue was found while trying to run SRU on a RPI2, the graphics/xorg-version will be marked as "passed" even if there is no X environment on that RPI2.
The detail section shows:
xdpyinfo: unable to open display ""

Related branches

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

good catch, actually it never fails due to the pipe commands.

We should instead use:

set -o pipefail; xdpyinfo | grep "^X.Org version" | cut -d ':' -f 2 | tr -d ' '

Changed in plainbox-provider-checkbox:
milestone: none → 0.28
status: New → Triaged
importance: Undecided → Medium
Revision history for this message
Po-Hsu Lin (cypressyew) wrote :

Nice, thanks for the tip! I will prepare a MR soon.

Changed in plainbox-provider-checkbox:
assignee: nobody → Po-Hsu Lin (cypressyew)
status: Triaged → In Progress
Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
milestone: 0.28 → 0.27
Po-Hsu Lin (cypressyew)
Changed in plainbox-provider-checkbox:
status: In Progress → Fix Committed
Pierre Equoy (pieq)
Changed in plainbox-provider-checkbox:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.