clocktest is not granular enough
Bug #1565863 reported by
Jeff Lane
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Checkbox Provider - Base |
Fix Released
|
Medium
|
Jeff Lane | ||
Bug Description
The current version of clocktest.c is not granular enough. It uses the basic time() function which returns only whole seconds and thus it can only measure clock skew or latency in whole seconds.
After a failure occurred and investigation revealed this, I discussed with the kernel team. their advice is that the largest deviation we should allow is 0.01 seconds, or 1/100th what we check for now. Even 0.01 is a huge deviation.
The test should be more fine-grained and accurate in the time it reports.
Related branches
lp:~bladernr/checkbox/update-clocktest
- Po-Hsu Lin: Approve
- Jeff Lane : Needs Resubmitting
-
Diff: 127 lines (+55/-14)3 files modifiedproviders/plainbox-provider-checkbox/jobs/cpu.txt.in (+1/-1)
providers/plainbox-provider-checkbox/src/Makefile (+1/-1)
providers/plainbox-provider-checkbox/src/clocktest.c (+53/-12)
Revision history for this message
| Jeff Lane (bladernr) wrote | #1 |
Revision history for this message
| Jeff Lane (bladernr) wrote | #2 |
| Changed in plainbox-provider-checkbox: | |
| milestone: | none → 0.27 |
| status: | In Progress → Fix Committed |
| Changed in plainbox-provider-checkbox: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
If you use gettimeofday() you can get both seconds and microseconds.