wireless/wireless_connection_wpa_bg_manual has wrong (impossible to complete) description

[Zygmunt Krynicki]

This is how the job definition looks like now:

----------------------8<-
plugin: user-interact-verify
name: wireless/wireless_connection_wpa_bg_manual
requires:
 device.category == 'WIRELESS'
 environment.ROUTERS == 'single'
user: root
environ: ROUTER_SSID ROUTER_PSK
command: trap "nmcli con delete id $ROUTER_SSID" EXIT; create_connection wifi $ROUTER_SSID --security=wpa --key=$ROUTER_PSK && gateway_ping_test --interface=`nmcli dev status | awk '/802-11-wireless/ {prin
estimated_duration: 120.0
_description:
 PURPOSE:
     Tests that the systems wireless hardware can connect to a router using WPA
     security and the 802.11b/g protocols.
 STEPS:
     1. Open your routers configuration tool
     2. Change the settings to only accept connections on the B and G wireless bands
     3. Make sure the SSID is set to ROUTER_SSID
     4. Change the security settings to use WPA2 and ensure the PSK matches that set in ROUTER_PSK
     5. Click the 'Test' button to create a connection to the router and test the connection
 VERIFICATION:
     Verification is automated, do not change the automatically selected result.
---------------------->8-

The description mentions ROUTER_SSID and ROUTER_PSK but the command clearly treats those as environment variables.

[Brendan Donegan (brendan-donegan)]

I agree the job descriptions could be a bit clearer. Any suggestions about phrasing are welcome. They need to convey the fact that the router_ssid option in the config file is the same as the router used to test.

In fact step 3 might not even be necessary - the user should already have configured the correct SSID.

[Zygmunt Krynicki (zyga)]

I've fixed this locally and will propose a branch with that.

On Wed, Feb 5, 2014 at 9:24 AM, Brendan Donegan <
<email address hidden>> wrote:

> I agree the job descriptions could be a bit clearer. Any suggestions
> about phrasing are welcome. They need to convey the fact that the
> router_ssid option in the config file is the same as the router used to
> test.
>
> In fact step 3 might not even be necessary - the user should already
> have configured the correct SSID.
>
> ** Changed in: checkbox
> Milestone: None => 2014-feb-14
>
> --
> You received this bug notification because you are a member of Checkbox
> Bug Wranglers, which is subscribed to checkbox.
> https://bugs.launchpad.net/bugs/1276150
>
> Title:
> wireless/wireless_connection_wpa_bg_manual has wrong (impossible to
> complete) description
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/checkbox/+bug/1276150/+subscriptions
>

[Brendan Donegan (brendan-donegan)]

@Zyga - do you have this branch? Can you propose it?

[Zygmunt Krynicki (zyga)]

Yeah, I exported that as a patch. I'll try to find and propose it.

[Daniel Manrique (roadmr)]

I'll poach this bug from you :) it won't make it in in time for this milestone, but will be fixed by the next one.

[Zygmunt Krynicki (zyga)]

Thanks a lot for fixing this :-)