rotation_test crashes when rotation is unsupported

[Jeff Lane ]

Testing a desktop with an nVidia card installed requiring the nVidia-current driver. Ran the rotation test and discovered that it crashed with an ugly traceback that is recreatable manually:

Traceback (most recent call last):
    File "/usr/share/checkbox/scripts/rotation_test, line 72, in <module> exit(main())
    File "/usr/share/checkbox/scripts/rotation_test, line 52, in main
        rots_statuses[rot] = (status, error)
UnboundLocalError: local variable 'error' referenced before assignment

The script didnt' work. On further investigation, the 'Displays' tool does not provide any options or rotations available, and this is bore out by looking at nvidia-settings which ALSO does not appear to provide any rotation options.

This script should probably be fixed to handle cases like proprietary drivers as well as provide a cleaner error in this case.

[Jeff Lane  (bladernr)]

ii checkbox 0.15+bzr1842+201212050848~precise1 System testing application
ii checkbox-certification 0.15+bzr556+201211161747~precise1 Checkbox Certification Tests
ii checkbox-certification-client 0.15+bzr556+201211161747~precise1 Client Certification
ii checkbox-qt 0.15+bzr1842+201212050848~precise1 QT4 interface for checkbox

[Zygmunt Krynicki (zyga)]

Oh, blast from the past. Let's see

[Zygmunt Krynicki (zyga)]

The script is clearly broken due to scoping rules in python3:

    for rot in rotations:
        try:
            raise xrandr.RRError # added to test this
            status = rotate_screen(rotations[rot])
        except(xrandr.RRError, xrandr.UnsupportedRRError) as error:
            status = 1
        else:
            error = 'N/A'
        # Collect the status and the error message
        rots_statuses[rot] = (status, error)

The variable 'error' is not in scope at the last line as it's only bound during the except handler.