disk/smart_sda will fail on a pristine disk

[Mark W Wenning]

Running certification on a Dell R530, got the following failure on disk/smart_sda :
Traceback (most recent call last): File "/tmp/nest-87rxzwdy.f56f5c335d0898316668afae86ba3e4d44df42982ade91867fd5a757b1949231/disk_smart", line 320, in <module> sys.exit(main()) File "/tmp/nest-87rxzwdy.f56f5c335d0898316668afae86ba3e4d44df42982ade91867fd5a757b1949231/disk_smart", line 292, in main previous_entries, returncode = get_smart_entries(disk) ValueError: need more than 1 value to unpack

Turns out this system contained a brand new disk that had never had the smart test run on it before.

In the disk_smart test, the first thing that get_smart-entries does is run "smartctl -l selftest /dev/sda", which will return 0 entries on a pristine disk, and exhibit the above failure.

Workaround is to manually run "sudo smartctl -t short /dev/sda" at least once to create an entry in the SMART selftest table.

File of my notes is attached.

[Daniel Manrique (roadmr)]

I took the liberty of assigning this to Rod, who recently overhauled the smart test and may be in a good position to fix this.

Rod, please let me know if you have time to look into this; if not, feel free to deassign yourself from the bug and I'll retriage it.

Cheers!

[Rod Smith (rodsmith)]

Mark, I *THINK* I've fixed this, but I don't have any pristine disks with which to test. If you can get access to such a disk, please test the version of disk_smart in https://launchpad.net/~rodsmith/checkbox/smart-newdisk. (I'll e-mail you the script directly, too.)

[Mark W Wenning (mwenning)]

I tried the new script on another pristine disk, and it looks like it is fixed.