Album art failed to download when using a proxy

[Vince Spicer]

the proxy settings where not being respected for album art downloads

patch in: http://bazaar.launchpad.net/~hacked/pithos/main/revision/65

[Kevin Mehall (kevin-mehall)]

Are you using a proxy because you're outside of the US, or because your network requires a proxy?

For non-US users, the HTTP proxy support in Pithos is designed to only proxy the control information, and send the audio streams directly. Pandora validates IPs only on the API servers, not the media servers. Are they performing IP checks on the album art as well, or is this unrelated to GeoIP issues?

Pithos uses your default system-wide HTTP proxy for the audio streams (Gstreamer does this by default). If album art is similarly not restricted to US IPs, it should use the system-wide proxy settings, not the one set in the Pithos preferences. This is so non-US users send minimal data over the US proxies, increasing speed and helping to not overload the proxies with unnecessary data.

There should probably be a note about this on the preferences dialog. And if you have a system-wide proxy set, it should be used as the control proxy by default.

In summary:
System-wide proxy settings = Proxy everything
Pithos proxy settings = control data only, for Pithos users outside the US

[Vince Spicer (hacked)]

Kevin,

I am outside of the US currently and only want to proxy the Pithos data. The audio stream works great with the current configuration but urllib was throwing errors and must have been being restricted due to the ip location.

Yes a system wide proxy would not have the issues. But my patch is working nicely to pull down the images through the proxy.

Vince

[Kevin Mehall (kevin-mehall)]

OK, it sounds like they are restricting access to the album art based on IP location then.

I'll merge your patch.

[Vince Spicer (hacked)]

Thank you sir, and nice work on the app.