Need a more informative log message when icons are missing

[Paul Lange]

I got this downstream error report, any idea what could cause this?

https://bugzilla.redhat.com/show_bug.cgi?id=821398

'gtk-close' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.

(Pinta:15191): GdkPixbuf-WARNING **: GdkPixbufLoader finalized without calling
gdk_pixbuf_loader_close() - this is not allowed. You must explicitly end the
data stream to the loader before dropping the last reference.

(Pinta:15191): GdkPixbuf-WARNING **: GdkPixbufLoader finalized without calling
gdk_pixbuf_loader_close() - this is not allowed. You must explicitly end the
data stream to the loader before dropping the last reference.
'gtk-new' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-new' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-new' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-new' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-new' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.
'gtk-missing-image' is not a valid resource name of assembly 'Pinta.Resources,
Version=1.3.0.0, Culture=neutral, PublicKeyToken=null'.

[Robert Nordan (rpvn)]

It's because the user doesn't have the needed gtk icons available in the theme he's using. (This problem has typically happened to KDE users, but if he's on GTK with a incomplete theme I suppose it could happen there as well.)

Before 1.3 it would make Pinta crash, for 1.3 we fixed it so that it wouldn't crash. Although I suppose we could probably print a more informative error message in the log whenever this happens, so that users will know what to do.

[Paul Lange (palango)]

So should I require the gtk icon set for the pitivi package?

[grofaty (grofaty)]

Just wondering, isn't this something package manager should do? You know adding some dependencies and if some icons are not installed then package manager should install them by itself.

[Robert Nordan (rpvn)]

In general requiring gnome-icon-theme-full or whatever the equivalent is on Fedora is certainly can't hurt, so I recommend you do that. It will probably solve the issue for a number of users.

But we've discovered that it seems it's not just a question of not just what you have installed, but that the particular theme you currently have selected has the required icons. (Not the best design choice from the GTK folks in my opinion.) Which is why we should probably clarify the error message as well.

[Paul Lange (palango)]

OK, will require the icon theme in the next version. Thanks for the input. From my side this can be closed.

[Robert Nordan (rpvn)]

Great, I think we'll keep it open to remind us to enhance the error message.