Pinta crashes when Paintbrush's Splatter type is used with size 1

[grofaty]

Pinta 1.0 on Windows XP sp3 / Ubuntu 11.04

1. Click on Paintbrush.
2. Set Brush width to 1.
3. Set Type to Splatter.
4. Start drawing on canvas and crash appears with the following text:
====================
Unhandled exception:
Exception has been thrown by the target of an invocation.

Details:
System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation. ---> System.ArgumentOutOfRangeException: 'minValue' cannot be greater than maxValue.

Parameter name: minValue

   at System.Random.Next(Int32 minValue, Int32 maxValue)

   at Pinta.Tools.Brushes.SplatterBrush.OnMouseMove(Int32 x, Int32 y, Int32 lastX, Int32 lastY) in C:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Tools\Brushes\SplatterBrush.cs:line 47

   at Pinta.Tools.Brushes.PaintBrush.DoMouseMove(Int32 x, Int32 y, Int32 lastX, Int32 lastY) in C:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Tools\Brushes\PaintBrush.cs:line 69

   at Pinta.Tools.PaintBrushTool.OnMouseMove(Object o, MotionNotifyEventArgs args, PointD point) in C:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Tools\PaintBrushTool.cs:line 147

   at Pinta.Tools.BaseBrushTool.OnMouseDown(DrawingArea canvas, ButtonPressEventArgs args, PointD point) in C:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Tools\BaseBrushTool.cs:line 137

   at Pinta.Tools.PaintBrushTool.OnMouseDown(DrawingArea canvas, ButtonPressEventArgs args, PointD point) in C:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Tools\PaintBrushTool.cs:line 91

   at Pinta.Core.BaseTool.DoMouseDown(DrawingArea canvas, ButtonPressEventArgs args, PointD point) in c:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Core\Classes\BaseTool.cs:line 97

   at Pinta.Gui.Widgets.PintaCanvas.<.ctor>b__2(Object sender, ButtonPressEventArgs e) in c:\Users\Jonathan\Documents\Visual Studio 2010\Projects\Pinta\Pinta.Gui.Widgets\Widgets\Canvas\PintaCanvas.cs:line 62

   --- End of inner exception stack trace ---

   at System.RuntimeMethodHandle._InvokeMethodFast(Object target, Object[] arguments, SignatureStruct& sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)

   at System.RuntimeMethodHandle.InvokeMethodFast(Object target, Object[] arguments, Signature sig, MethodAttributes methodAttributes, RuntimeTypeHandle typeOwner)

   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture, Boolean skipVisibilityChecks)

   at System.Delegate.DynamicInvokeImpl(Object[] args)

   at GLib.Signal.ClosureInvokedCB(Object o, ClosureInvokedArgs args)

   at GLib.SignalClosure.Invoke(ClosureInvokedArgs args)

   at GLib.SignalClosure.MarshalCallback(IntPtr raw_closure, IntPtr return_val, UInt32 n_param_vals, IntPtr param_values, IntPtr invocation_hint, IntPtr marshal_data)
====================

[grofaty (grofaty)]

Actually Pinta does not crash, just giving this error in endless loop when clicking on "x" of error message.

[Cameron White (cameronwhite91)]

Fixed: https://github.com/PintaProject/Pinta/commit/8a1e242539ef240dd7e3836557e0b118517bca4f

[grofaty (grofaty)]

Tested Pinta 1.1 on Windows XP sp3. Problem solved.