Color Range slider doesn't do anything for Pencil Sketch or Ink Sketch effects

Bug #747607 reported by Huy on 2011-04-01
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
Medium
Unassigned

Bug Description

Pencil Streck - Color Range does not affect result
I have fixed this bug on my side.
You have to force bacAdjustment to calculate again.
To do this you have to change "bacAdjustment.table_calculated = false" (this field is currently private, should change to internal for a hack)

grofaty (grofaty) wrote :

Can you please write step by step instruction how to reproduce a problem? Can you please also post a Pinta version and operating system you are running it on?

Huy (hkervn2001) on 2011-04-03
summary: - Pencil Streck - Detail does not affect
+ Pencil Streck - Color Range does not affect

- Open an image
- Go to menu: Effects\Artistic\Pencil Sketch
- Drag "Color Range" => not affect.

To Fix this bug:
-Open file PencilSketchEffect.cs
update
          bacAdjustment.Data.Brightness = Data.ColorRange;
   bacAdjustment.Data.Contrast = - Data.ColorRange;
to
                        bacAdjustment.table_calculated = false;
   bacAdjustment.Data.Brightness = Data.ColorRange;
   bacAdjustment.Data.Contrast = - Data.ColorRange;

- Open BrightnessContrastEffect.cs
update
                        private bool table_calculated;
to
                        internal bool table_calculated;

Thanks

description: updated
Shrimp (shrimpie) wrote :

What's he is saying is that changing the Color Range value has no effect (meaning it doesn't work).

1. Open an image (preferably one with lots of color).
2. Go to Effects ---> Artistic ---> Pencil Sketch...
3. Change the Color Range slider (nothing happens)

I guess the stuff at the end of his post is the patch?

Shrimp (shrimpie) wrote :

Hmmm, the problem also seems to exist in the Ink Sketch effect. The Color slider doesn't do anything.

Changed in pinta:
importance: Undecided → Medium
status: New → Confirmed
summary: - Pencil Streck - Color Range does not affect
+ Color Range slider doesn't do anything for Pencil Sketch or Ink Sketch
+ effects
Cameron White (cameronwhite91) wrote :

Fixed: https://github.com/PintaProject/Pinta/commit/c3ff46b815e1042fbdb349639f5f24e64c05f2ef

Even with the color range slider working, the color range value doesn't have a huge effect on the Pencil Sketch appearance.
However, the color range has a very noticeable effect on the Ink Sketch.

Changed in pinta:
status: Confirmed → Fix Committed
Robert Nordan (rpvn) on 2011-11-14
Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers