Get into full screen and menus and buttons disappear

[grofaty]

I have downloaded the latest master build for Linux: https://github.com/PintaProject/Pinta/actions/runs/7278443090/artifacts/1127062967

Start Pinta and press F11 key to get into full screen mode.
Problem appears. There are no menu options (at top right)
and no buttons (New, Open, Save, etc).

This is regression from Pinta 2.1.1. See attachment.

[Cameron White (cameronwhite91)]

Confirmed, this probably happened from switching to using a header bar - since that's part of the window decorations it doesn't appear when in full screen.

[Cameron White (cameronwhite91)]

https://gnome.pages.gitlab.gnome.org/libadwaita/doc/main/migrating-to-breakpoints.html#fullscreen-header-bar has some ideas, depending on whether we choose to require libadwaita 1.4 (currently 1.2)

[James Carroll (james-carroll)]

Both the Flatpak and Snap already ship with lib adwaita 1.4, so the version requirements only really generalise to distro native packaging. Ubuntu 22.04 is too old for Pinta 2.2 as is, and I'd imagine most other distros are either rolling release or have shorter lifecycles (Fedora/Arch/Gentoo/etc), so their native packages are likely to be modern.

IMO, I could imagine 90% of users wouldn't have a material difference between 1.2 and 1.4, because they're either using Snap/Flatpak, or they're on distributions with faster release cadences anyway.

[Cameron White (cameronwhite91)]

Ah thanks, that's good to know! I wasn't sure if the snap packages were doing anything based on the LTS repos. I think I'd be okay with targeting the newer version then if it works with Snap and Flatpak

Is GTK 4.12 also the GTK version being used? I think from what I see, libadwaita 1.4 requires GTK >= 4.11

[James Carroll (james-carroll)]

The core 18/20 Snap Gnome packages had explicit versioning, e.g, core 20 had 3.34 and 3.38 - naively I'd been assuming then that the extension for core22 was also frozen in time which would have been a concern for Pinta 2.2. But I guess since GTK3 is now EOL it's not at risk of incompatibility; and presumably GTK4 must be forwards compatible, because it's actually upgraded from 4.6 to 4.12 without explicitly choosing a new version, meaning quite literally, the Pinta 2.1 snap already has GTK4.12 / libadwaita 1.4 available to use already, it just happens to be avoiding them to use GTK3 instead.

For the Flatpak, they've the latest libraries from the Gnome 45 release, which I assume has to cover GTK4.12 and awaita 1.4 too; although I can't 100% confirm it because I don't understand the project structure. This means the Flatpak might just have to update the runtime dependency they use, but there should probably already be one.

For the snap, it's literally as simple as removing the source-commit so it builds master implicity; it already works with 2.2 without any changes :)

[Cameron White (cameronwhite91)]

OK great, that sounds good :) Yeah I think the flatpak should likely work as long as the runtime is upgraded

[grofaty (grofaty)]

Command:
flatpak info com.github.PintaProject.Pinta

ID: com.github.PintaProject.Pinta
Runtime: org.gnome.Platform/x86_64/45
Sdk: org.gnome.Sdk/x86_64/45

Pinta/flatpak already is using Gnome 45.

From Gnome 45 release page: https://release.gnome.org/45/developers/ where it is stated: "GNOME 45 is accompanied by GTK 4.12."

[Cameron White (cameronwhite91)]

With https://github.com/PintaProject/Pinta/commit/a3ab26d013b09746aca0ab99f39ffb607e7b9e2e the header bar should now stay visible in full screen mode

[grofaty (grofaty)]

I can confirm this is now fixed in Pinta 2.2-dev latest master https://github.com/PintaProject/Pinta/actions/runs/7319169976/artifacts/1133820048 on Ubuntu 23.10. Thanks for fixing.