Menu icons are GONE in Pinta 2.0

[Rega Fox]

Regression from version 1.8

This is on Manjaro 21.2.2

[Cameron White (cameronwhite91)]

This disappeared in the GTK3 port, but not exactly on purpose .. GtkImageMenuItem was deprecated in GTK3 (https://docs.gtk.org/gtk3/class.ImageMenuItem.html) and Pinta also switched to using gio for menus (https://docs.gtk.org/gio/class.Menu.html).

It looks like there is actually a way to get menu icons with it: https://docs.gtk.org/gio/method.MenuItem.set_icon.html, however there are a couple big issues I see:
- AFAIK there isn't a GTK setting to turn this off, like there was in GTK2 with the 'gtk-menu-images' setting that many distros had off by default. So they would show up for everyone and might look very inconsistent with other applications on the system, and I'm not sure this is a good thing
- We'd also be violating the GTK design guidelines, which say that this is intended for 'noun' menu items like bookmarks, and not for 'verb' items like Open or Save

[Rega Fox (regafox)]

" - We'd also be violating the GTK design guidelines, which say that this is intended for 'noun' menu items like bookmarks, and not for 'verb' items like Open or Save"

I don't want to be rude but that seems really stupid.

All it does is hurt productivity. (to a small degree)

If there is some icons missing in an application, it just looks silly.

But having that in the design guidelines makes no sense, unless this is only temporary and the plan is to load default system icons. That would be fine for me.

The issue is that a symbol takes less time to recognize and they were close enough to Paint.NET that i never had problems finding something in the menus.

[Cameron White (cameronwhite91)]

Related thread from Inkscape which also encountered this: https://bugs.launchpad.net/inkscape/+bug/1636493

I don't mind adding a preference for this as long as it's off by default. It could e.g. go under the View -> Show/Hide menu

[Rega Fox (regafox)]

Yes, that would be fine by me.

[Jonathan Pobst (jpobst)]

Another downside to menu icons is we will have to come up with all new icons to be dark-theme compliant.

[Cameron White (cameronwhite91)]

That's a good point, with all the changes in the master branch to improve dark theme support. Many of those icons might need a dark theme compliant version regardless, though, since they can show up in the history panel?

[Jonathan Pobst (jpobst)]

Some of them yeah. But like I would suggest a single generic history icon for all adjustments and effects. Trying to find/make an icon for each one would probably not be fun.

[grofaty (grofaty)]

- Aren't History icons the same icons as in Tools, it looks to me so?
- Do we really need icons on History panel?

Just a note, to be dart-theme compliant there should also be new mouse icons, which is actually another point not strictly related to menu icons.

[Cameron White (cameronwhite91)]

Yeah, I'd be okay with a more limited set of icons in the history view, unless someone with design skills wants to tackle that :)

The history icons are usually from whatever tool generated the history item, or similarly from whatever effect was applied