Close dialog with "x" on tab and save & close does not work (regression)

[grofaty]

Pinta 1.8 dev on Ubunu 20.04:
https://github.com/PintaProject/Pinta/actions/runs/453364003

1. New image.
2. Rectangle and draw on canvas.
3. Click on "x" on image tab to close the image.
4. "Save changes to image..." dialog appears.
5. Click on Save button.
6. In Name field type in some image file name and Save button at the top right of the window.
Problem appears. It looks like file gets named, but in step 3 I have chosen to close the file, so file should get saved (this works fine), but file should also get closed down.

I tested on Pinta 1.7 on Ubuntu 20.04 and this problem does not appear, so regression in Pinta 1.8.

[grofaty (grofaty)]

I checked Pinta 1.7 source code and compared it with Pinta 1.8. It appears there are differences in file Pinta/Actions/File/CloseDocumentAction.cs

See attachment.

[grofaty (grofaty)]

It looks like this problem only appears at some of the tools.

In step 2 if I select Rectangle or Line for example the problem appears.
In step 2 if I select Pencil or Paintbrush then problem does not appear.

[grofaty (grofaty)]

In step 3 if Window | Close All is selected, then the same problem appears.

[Cameron White (cameronwhite91)]

Confirmed, this also occurs in the latest master (not just the GTK3 build)
I tracked this down to https://github.com/PintaProject/Pinta/commit/d58ab5b21ebe77612a7e23eb259e45002a3236f1

[Cameron White (cameronwhite91)]

Fixed by https://github.com/PintaProject/Pinta/commit/96304cbb8a6081141e936a5d093cc795aeef03f1 (and https://github.com/PintaProject/Pinta/commit/aaae6085ae66c93937224b9788b772e80abfc8b9 for the GTK2 branch)

[grofaty (grofaty)]

Pinta 1.8-dev on Ubuntu 20.04:
https://github.com/PintaProject/Pinta/actions/runs/454798621

I can confirm this is now fixed. Thanks.

P.S. I have retested Pinta 1.7 on Ubuntu 20.04 from snap package: https://snapcraft.io/pinta-james-carroll and it is working fine. Probably snap does not include master branch commits. It probably only contains fixes from official 1.7 release. That would explain why it works in my case.