Icons are difficult to see in dark theme

[andrybak]

I am using dark Ambiance theme. Some of the UI elements do not comply with the theme, are distracting and sometimes hard to read.

Following elements are displayed incorrectly:

* Tabs for opened images are brightly colored.
* Titlebars for the tool windows (Palette, Layers, History, Tools) are hard to read.
* Lightly colored panels on tool windows make disabled buttons hard to see.

All items can be seen on the screenshot attached.

[Hildo Guillardi Júnior (hildogjr)]

Confirmed on Ubuntu 20.04

[grofaty (grofaty)]

Yesterday I have migrated my laptop from Ubuntu 18.04 to Ubuntu 20.04. By default Ubuntu 18.04 does not have dark theme. Users wanted to have dark mode were required to install third party theme from third party web site. Now in Ubuntu 20.04 dark mode is there included in default installation. Users now don't need to do anything - see ubuntu_appearance_settings.png attachment.

Comparing original problem reporter and my Ubuntu 20.04 look and feel, I see now problems went from bad to worse. See dark_theme.png attachment.

Problems:
- Panels names are not not seen at all.
- Icons like Lasso Select, Text and Line/Curve are not recognizable.

Like I see it (and like I understand Gnome theming) we have at least two group of problems with dark mode:
1. Theming - this is related to colors of different objects. You set color for particular object and problem is solved.
2. Icons - independent of theming there are icons that are not compatible to dark mode. Changing theming colors do not fix icons. Icons must be compatible with dark mode - in some cases like I see whole new icons are used. We have options: a) make icons that look great in light and dark mode (difficult to accomplish), b) create separate icons for dark mode (a lot of work), c) make panel background independent of mode - for example make background panels dark grey in both modes (and make sure icons look great on this new background).

[Cameron White (cameronwhite91)]

I think we might be able to check https://developer.gnome.org/gtk3/3.2/GtkSettings.html#GtkSettings--gtk-application-prefer-dark-theme to select better icons. Some of the upcoming GTK3 changes will also make it easier for custom themed icons to override the default icons.

[Cameron White (cameronwhite91)]

I think this is largely fixed now with the GTK3 port (and the docking library changes)
The remaining issue is just that some of the custom icons in Pinta are a bit hard to see under a dark theme
Contributions for this are very welcome, but I'm not sure this should block the 1.8 release which is long overdue

[grofaty (grofaty)]

I have tested latest Pinta development on Ubuntu 20.04 in dark theme and I also see huge improvements. I normally do not use dark theme, so any comments from original reporter is welcome.

P.S. I also agree this bug report should not be show stopper for releasing new Pinta version, because it will not affect most of the people, just he ones that manually change theme.

[tgvbjhknlm (tgvbjhknlm)]

History text is black in a dark theme. I am using Adwaita-Dark on Gnome Manjaro, and all other text looks white but the history text is black. I think it must be a brighter colour.

https://i.imgur.com/KFxg1Wj.png

[Cameron White (cameronwhite91)]

I think that's fixed already on the master branch, by https://github.com/PintaProject/Pinta/pull/207

[Cameron White (cameronwhite91)]

I think this is fixed now with the icon changes in Pinta 2.1