Delete key does not finishes rectangle selection

Bug #1424629 reported by grofaty on 2015-02-23
12
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Pinta
Medium
Cameron White

Bug Description

Pinta dev 1.6.0.104 on Windows 7.

1. New image.
2. Rectangle Select and mark some area on canvas
3. Press Delete key to delete marked area.
4. I would like to select another area from right-bottom down. Move mouse to the right-bottom edge of deleted area and what happens 'hand icon' appears.
5. Now at this exact same location (right-bottom of previous selection and hand icon displayed) mark another rectangle select. What happens? Instead of new rectangle area selected a resize selection is performed.

In my humble opinion Delete (or Backspace) key should finalize the rectangle selection, but they don't.

This is most probably a regression problem. I don't remember ever getting into this problem and using Pinta for years.
It may be because of commit: https://github.com/PintaProject/Pinta/commit/d77e113a405b33cd12f7ac0d1042e1d3f0da16ed

grofaty (grofaty) wrote :
Changed in pinta:
importance: Undecided → Medium
milestone: none → 1.6
status: New → Confirmed
Jonathan Pobst (jpobst) wrote :

- PDN deselects the area after clearing it
- PS leaves the area selected after clearing it

I'm pretty sure Pinta has always left the area selected after clearing it. It seems like a pretty common workflow to delete an area and then want to do something new in the area, like a bucket fill or an effect. It would be annoying to have to redraw your selection after the clear. (Especially if it's a complex selection like freeform.)

The new issue is that the selection drag handles disappear after clearing it (since they are new). I think the proper fix is to simply ensure that the drag handles are still visible after clearing the selection.

Cameron White (cameronwhite91) wrote :

I think the correct fix will be a bit more complicated, and possibly should wait for 1.7.

Currently, the select tool overrides OnCommit() to clear the tool layer (which hides the selection handles), and a ton of things implicitly rely on this behavior, like saving images (bug 887574) , the Deselect command, etc. This is why the selection handles disappear when pressing the Delete key.

I think the proper fix is to provide a way to get a list of the non-guide layers (which would fix the saving issue), remove the OnCommit implementation, and then ensure that the Select tool is properly notified when the selection is modified elsewhere in Pinta.

grofaty (grofaty) wrote :

Cameron, I agree with you. This is not a big issue for me, so it can wait for 1.7. Probably better then change too many code and make new bugs/instability into existence.

I also agree with Jonathan, there should be Delete to finalize or (probably even better) to not lose small blue rectangles for resizing.

Changed in pinta:
milestone: 1.6 → 1.7
Cameron White (cameronwhite91) wrote :
Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
status: Confirmed → Fix Committed
grofaty (grofaty) wrote :

Tested in 1.7.0.202 on Ubuntu 14.04 and Delete key properly deletes selected area and leaves blue selection rectangles for resize.
Compared with official 1.6 where Delete key deletes selected area but blue selection rectangles disappear (a problem).

Thanks a lot for fixing this issue.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers