Tools from add-ins sometimes appear before the default tools

[Cameron White]

The Random Pencil tool from the Demo Extension was always appearing at the top of my Tools palette, before any of the default tools. However, uninstalling and reinstalling the tool seemed to fix this, and it's now appearing at the bottom of the Tools palette. I still haven't figured out what sequence of actions caused the original issue to occur.

Probably not a release blocker, unless other people are seeing this.

[Robert Nordan (rpvn)]

From Pinta's perspective both the core and any other add-ins are just add-ins; it doesn't make a distinction. It's possible that the order of loading is non-deterministic.

[Cameron White (cameronwhite91)]

Yeah, it seems like that's the case (the Random Pencil tool has now returned to the top of my tools palette). There's probably not much we can do about that, though.

[Robert Nordan (rpvn)]

Actually, it seems there are facilities in place for that already: https://github.com/PintaProject/Pinta/blob/master/Pinta.Core/Managers/ToolManager.cs#L55

All the tools and brushes are sorted with a comparer function after adding which checks the BaseTool Priority value. When equal, they just get piled in in the order of loading, and right now they're all equal. The default Priority is 75, if we just make the Core Tools have Priority values lower than that they should always be first. (Provided no add-in maker gets cute and gives his/her add-in an even lower number.)

[Cameron White (cameronwhite91)]

It doesn't look like the ToolboxWidget supports that yet (there's a TODO comment in that file to support sorting), but I think that system would work well.

[Cameron White (cameronwhite91)]

I think this got fixed in Pinta 2.0 with https://github.com/PintaProject/Pinta/commit/c785eeed6f3301779875fb0fd0276a28577f3899, and https://github.com/PintaProject/Pinta/commit/14a6cfdc6ac4e8f4c81bc229d7b4c6975dfb4398 fixes a regression with it in Pinta 2.2