Undo is broken for cropping or resizing the canvas

Bug #1036485 reported by Cameron White on 2012-08-14
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Pinta
High
Cameron White

Bug Description

This worked in Pinta 1.3, so it was broken since then.

Steps to reproduce:
1) Create a new image (e.g. 800x600)
2) Resize Canvas -> resize to 120%
3) Press Ctrl+Z, and the previous state isn't restored correctly (see attached image)

This can also be reproduced using Crop to Selection (see attached image) or AutoCrop

Cameron White (cameronwhite91) wrote :
Cameron White (cameronwhite91) wrote :

Here is a screenshot of what happens with undoing a Crop to Selection

Cameron White (cameronwhite91) wrote :

This also broke undo for Merge Layer Down (the bottom layer isn't restored to its previous state).

I tracked this regression down to the SurfaceDiff addition (https://github.com/PintaProject/Pinta/pull/19)

Cameron White (cameronwhite91) wrote :

Undo for Flatten Image was also broken in the same manner as Merge Layer Down

Cameron White (cameronwhite91) wrote :

I committed a fix for Merge Layer Down and Flatten Image: https://github.com/PintaProject/Pinta/commit/56828ac4722809b1a08e916e714cc24b6cca9e14

Changed in pinta:
assignee: nobody → Cameron White (cameronwhite91)
status: Triaged → In Progress
Cameron White (cameronwhite91) wrote :
Changed in pinta:
status: In Progress → Fix Committed
grofaty (grofaty) on 2012-09-27
Changed in pinta:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers