phraymd

Red/pink thumbnails and pictures

Bug #1013587 reported by LCG
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
phraymd
Fix Committed
Undecided
Unassigned

Bug Description

Hello,

Some pictures don't have thumbnails. Appears a red/pink square instead and I can't load the full picture by double-clicking.

1. It happens with some of my old file. It was scans from negatives film then worked with Photoshop CS2 (don't know if it helps you).
"Recreate Thumbnail" doesn't work. Here's the output :
-------------------------------
forcing thumbnail creation
MAKING THUMB FOR Archives/nico/travail/ChampionnatFrance_Judo_2008/Mon_judo/01/DSC_0309 (2).jpg /media/HDIMAGES/Archives/nico/travail/ChampionnatFrance_Judo_2008/Mon_judo/01/DSC_0309 (2).jpg
resize time 0.0305740833282
creating FAILED thumbnail Archives/nico/travail/ChampionnatFrance_Judo_2008/Mon_judo/01/DSC_0309 (2).jpg
resize time 0.0235450267792
----------------------------------------

2. It happens with .tiff files
"Recreate thumbnail" output :
-------------------------------
forcing thumbnail creation
MAKING THUMB FOR 2011/2011-10/2011-10-31-toulon-ben-marie/hdr__MAY1150_8.tif /media/HDIMAGES/2011/2011-10/2011-10-31-toulon-ben-marie/hdr__MAY1150_8.tif
/media/HDIMAGES/2011/2011-10/2011-10-31-toulon-ben-marie/hdr__MAY1150_8.tif has no thumbnail.
Cannot decode file /media/HDIMAGES/2011/2011-10/2011-10-31-toulon-ben-marie/hdr__MAY1150_8.tif
creating FAILED thumbnail 2011/2011-10/2011-10-31-toulon-ben-marie/hdr__MAY1150_8.tif
----------------------------------------

Revision history for this message
LCG (le-coude-gauche) wrote :
Revision history for this message
dmoore (damien-moore) wrote : Re: [Bug 1013587] Re: Red/pink thumbnails and pictures

Thanks for the report.

Are you using the option "Use embedded thumbnails if available"? If
so, a current limitation is that if there is no embedded thumbnail
there is no way to create it. This feature is still a little
experimental and I plan to improve it.

If you haven't checked this option, then this is probably a limitation
of the thumbnailing code. I am using the python imaging library or
dcraw to create thumbnails for most image types. I can probably come
up with an alternative way to retrieve the thumbnails. It would be
helpful if you could share some of these files with me (either email
them to me or host them somewhere I can download them).

Revision history for this message
dmoore (damien-moore) wrote :

Rev 587 adds a GTK fallback to Python Imaging (PIL) for thumbnailing
and viewing full size images. See if this helps.

On Fri, Jun 15, 2012 at 10:27 PM, Damien Moore <email address hidden> wrote:
> Thanks for the report.
>
> Are you using the option "Use embedded thumbnails if available"?  If
> so, a current limitation is that if there is no embedded thumbnail
> there is no way to create it. This feature is still a little
> experimental and I plan to improve it.
>
> If you haven't checked this option, then this is probably a limitation
> of the thumbnailing code. I am using the python imaging library or
> dcraw to create thumbnails for most image types. I can probably come
> up with an alternative way to retrieve the thumbnails. It would be
> helpful if you could share some of these files with me (either email
> them to me or host them somewhere I can download them).

Revision history for this message
LCG (le-coude-gauche) wrote :
Download full text (3.5 KiB)

I'm not using the "Use embedded thumbnails if available" option as there was to much missing thumbnails.

1. I tried to "recreate thyumbnails" with the last version on one picture and it works
Output :
--------------------
Forcing thumbnail creation
Creating thumbnail for Archives/GALERIE_IMAGES/archives/Reunion_de_Paysage/02.jpg /media/HDIMAGES/Archives/GALERIE_IMAGES/archives/Reunion_de_Paysage/02.jpg
Opened with GDK
---------------------

2. Then I made a selection of 9 pictures and Phraymd seems to hang on (crashed but opened)
Here what I have in the terminal :
------------------------------
Forcing thumbnail creation
2012-06-16 09:40:09,912 - phraymd core - ERROR
Error on Worker Thread
Traceback (most recent call last):
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 1197, in _loop
    if job():
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 295, in __call__
    c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg = True)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py", line 783, in make_thumbnail
    imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 665, in make_thumb
    delete_thumb(item)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 583, in delete_thumb
    io.remove_file(item.thumburi) ##TODO: What if item is in gnome cache? (This will probably work, but maybe not the best way to remove items from cache?) commented code below doesn't look right (deleting twice?)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/io.py", line 152, in remove_file
    raise IOError ##todo: reuse the error message
IOError

ERROR:phraymd core:Error on Worker Thread
Traceback (most recent call last):
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 1197, in _loop
    if job():
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 295, in __call__
    c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg = True)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py", line 783, in make_thumbnail
    imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 665, in make_thumb
    delete_thumb(item)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 583, in delete_thumb
    io.remove_file(item.thumburi) ##TODO: What if item is in gnome cache? (This will probably work, but maybe not the best way to remove items from cache?) commented code below doesn't look right (deleting twice?)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/io.py", line 152, in remove_file
    raise IOError ##todo: reuse the error message
IOError

INFO:phraymd core:Abandoning Highest Priority Task RECREATETHUMB and Resuming Worker Loop
-----------------------------------

Hum! I h...

Read more...

Revision history for this message
dmoore (damien-moore) wrote :
Download full text (4.3 KiB)

Might be a race condition between the thumbnailer and browser. Try
scrolling the images that are missing out of the view after you select
recreate and see if that helps.

I didn't have problems with the 3 images you linked. But the images loaded
correctly first time, so that probably makes a difference.
On Jun 16, 2012 4:00 AM, "LCG" <email address hidden> wrote:

> I'm not using the "Use embedded thumbnails if available" option as there
> was to much missing thumbnails.
>
> 1. I tried to "recreate thyumbnails" with the last version on one picture
> and it works
> Output :
> --------------------
> Forcing thumbnail creation
> Creating thumbnail for
> Archives/GALERIE_IMAGES/archives/Reunion_de_Paysage/02.jpg
> /media/HDIMAGES/Archives/GALERIE_IMAGES/archives/Reunion_de_Paysage/02.jpg
> Opened with GDK
> ---------------------
>
> 2. Then I made a selection of 9 pictures and Phraymd seems to hang on
> (crashed but opened)
> Here what I have in the terminal :
> ------------------------------
> Forcing thumbnail creation
> 2012-06-16 09:40:09,912 - phraymd core - ERROR
> Error on Worker Thread
> Traceback (most recent call last):
> File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py",
> line 1197, in _loop
> if job():
> File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py",
> line 295, in __call__
> c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg
> = True)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py",
> line 783, in make_thumbnail
>
> imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py",
> line 665, in make_thumb
> delete_thumb(item)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py",
> line 583, in delete_thumb
> io.remove_file(item.thumburi) ##TODO: What if item is in gnome cache?
> (This will probably work, but maybe not the best way to remove items from
> cache?) commented code below doesn't look right (deleting twice?)
> File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/io.py", line
> 152, in remove_file
> raise IOError ##todo: reuse the error message
> IOError
>
>
> ERROR:phraymd core:Error on Worker Thread
> Traceback (most recent call last):
> File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py",
> line 1197, in _loop
> if job():
> File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py",
> line 295, in __call__
> c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg
> = True)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py",
> line 783, in make_thumbnail
>
> imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py",
> line 665, in make_thumb
> delete_thumb(item)
> File
> "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py",
> line 583, in delete_thumb
> io.remove_file(item.thumburi) ##TODO: What if item is in gnome cach...

Read more...

Revision history for this message
dmoore (damien-moore) wrote :

Try updating to revision 594. I think this should fix the race condition.

Revision history for this message
LCG (le-coude-gauche) wrote :

Hello,

I still have problems with pictures from the serie below. The 3 pictures I linked have now thumbnails but I can't recreate thumbnails for two other ones.

The output seems to be the same :
------------
Forcing thumbnail creation
2012-06-20 09:23:50,679 - phraymd core - ERROR
Error on Worker Thread
Traceback (most recent call last):
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 1196, in _loop
    if job():
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 296, in __call__
    c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg = True)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py", line 801, in make_thumbnail
    imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 665, in make_thumb
    delete_thumb(item)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 583, in delete_thumb
    io.remove_file(item.thumburi) ##TODO: What if item is in gnome cache? (This will probably work, but maybe not the best way to remove items from cache?) commented code below doesn't look right (deleting twice?)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/io.py", line 152, in remove_file
    raise IOError ##todo: reuse the error message
IOError

ERROR:phraymd core:Error on Worker Thread
Traceback (most recent call last):
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 1196, in _loop
    if job():
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/backend.py", line 296, in __call__
    c.make_thumbnail(item,None,True) ##force creation of thumbnail (3rd arg = True)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/collectiontypes/localstorebin.py", line 801, in make_thumbnail
    imagemanip.make_thumb(item,self,interrupt_fn,force,self.thumbnail_cache_dir)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 665, in make_thumb
    delete_thumb(item)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/imagemanip.py", line 583, in delete_thumb
    io.remove_file(item.thumburi) ##TODO: What if item is in gnome cache? (This will probably work, but maybe not the best way to remove items from cache?) commented code below doesn't look right (deleting twice?)
  File "/home/nico/UTILITAIRES/phraymd/phraymd/modules/phraymd/io.py", line 152, in remove_file
    raise IOError ##todo: reuse the error message
IOError

INFO:phraymd core:Abandoning Highest Priority Task RECREATETHUMB and Resuming Worker Loop
------------------------

Oooups. . .
Re-running Phraymd and it works now. Still don't understand what have happened but everything is OK now.
Thank you.

dmoore (damien-moore)
Changed in phraymd:
status: New → Fix Committed
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.