themecontrol.php replacing {prepath} incorrectly

[Todd]

{prepath} is not being replaced correctly by themecontrol.php when SSL is in use.

[alecwh (alecwh)]

Can you give some more details about the problem? What is the difference between SSL/non-SSL? What is being replaced, if anything?

[Todd (tpat)]

The problem lies at line 50 in themecontrol.php:

$file = str_replace('{prepath}','http://'.$_SERVER['SERVER_NAME'].$uri,$file);

In our case we are only using https. Therefore, every tag in the default theme that may use {prepath} for the url is incorrect. Right now it appears that the only tag using this is the link tag so the stylesheet is not loading.

A simple fix would be to check whether the server is using SSL or not:

$file = str_replace('{prepath}','http'.($_SERVER['HTTPS'] == "on" ? 's':'').'://'.$_SERVER['SERVER_NAME'].$uri,$file);

[alecwh (alecwh)]

Thanks for your fix. This will make it into the next patch/release!

[alecwh (alecwh)]

in the latest revision