Empty control panel present arbitrary menu item

Bug #1011661 reported by Greg on 2012-06-11
This bug affects 1 person
Affects Status Importance Assigned to Milestone

Bug Description

When a give menu item is an alias of the "control panel", but is empty, it shows the icon of an arbitrary menu item (in my case "optimise database").

This is why:

in controlPanel.query.php, line 163 and following, the $nav is looped on to fill $this->cp[].

after this loop, if $this->cp[] is empty, this code is executed:

   if (empty($this->cp)) {
    $this->cp[$m['menu_id']] = $m['menu_id'];

I don't understand the meaning of this, since, $m is the last iteration of the loop, it's clealry not desireable. I think these lines can be delete, why maybe there's a reason for them being here?

Greg (gregfr) on 2012-06-11
Changed in phpdevshell:
importance: Undecided → Medium
Greg (gregfr) on 2012-06-12
Changed in phpdevshell:
assignee: nobody → Greg (gregfr)
status: New → Fix Committed
Greg (gregfr) on 2012-07-27
Changed in phpdevshell:
milestone: none → 3.2.1-stable
Greg (gregfr) on 2013-06-11
Changed in phpdevshell:
milestone: 3.2.1-stable → 3.5
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers