Photostory window has no icon

Bug #724328 reported by Josh Brown
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Photostory
Fix Committed
Undecided
David Turner

Bug Description

`window.set_icon_from_file("photostory.svg")` will only work when `photostory.svg` is in the current directory (which will usually be the user's home directory in this case). Therefore the Photostory window will not have an icon in most cases (but is likely to have one when tested directly from the branch).

Related branches

Revision history for this message
David Turner (dwt) wrote :

I can confirm this. I'll see if I can get a fix up.

Changed in photostory:
assignee: nobody → David Turner (finalfantasykid13)
status: New → Confirmed
David Turner (dwt)
Changed in photostory:
status: Confirmed → Fix Committed
Revision history for this message
Josh Brown (joshbrown) wrote :

`sys.path[0]` is unnecessary so I've removed it in lp:~photostory/photostory/code, revision 44; please correct me if I'm wrong.

Also, giving an exact path seems like a poor way of finding an icon; if someone were using a theme that includes a different version of the Photostory icon we would want to use that icon rather than the default one. Ideally we would want to use some sort of XDG method of retrieving the icon. As everything works okay as it is, this isn't massively important.

Revision history for this message
Josh Brown (joshbrown) wrote :

Forgot to mention: Photostory will install to /usr/local/... when installed from the setup.py directly. In this case, no icon will be displayed.

Revision history for this message
David Turner (dwt) wrote :

The reason sys.path[0] is in there is because other wise if during development you run the program from a different directory, it will look for the icon in the current working director, rather than from the directory where the program is actually located.

And your probably right about the hardcoded path.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.