don't display inappropriate quickstart results

Bug #1604453 reported by Kyle Nitzsche
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Photos Scope
Fix Released
High
Penk Chen
Today Scope
Fix Released
High
Penk Chen
scope-aggregator
Fix Released
High
Kyle Nitzsche

Bug Description

scope-aggregator should not display quickstart help for child scopes that are not installed or for Settings> Accounts for inappropriate locales.

For example, the photos scope displays help that includes a login result for facebook (photos), even if the facebook photos child scope is not installed.

Another example, Today scope should not display a button to open Settings > Accounts > Google in China.

Tags: ota13

Related branches

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Here is a screenshot of the facebook quick start result (in China) that should not be displayed.

Changed in photos-scope:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Kyle Nitzsche (knitzsche)
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

This also affects today-scope because the quick start help should not display a result allowing the user to open Settings > Accounts > Google in China.

Changed in today-scope:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Kyle Nitzsche (knitzsche)
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Here is photos-scope 4.11.0.

In any of these conditions, quick start help should NOT display a result for facebook (or any other child scope mentioned in hints.json):

* facebook scope (com.canonical.scopes.fbphotos) is not installed
* facebook scope is installed, but the user is already logged in

In this condition, quick start help SHOULD display a result for facebook (or any other chilld scope mentioned in hints.json):

* facebook scope is installed, but the user is not logged in

Changed in photos-scope:
status: Confirmed → Fix Committed
tags: added: ota13
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :
summary: - don't display quickstart content for child scopes not installed
+ don't display inappropriate quickstart results
description: updated
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

fixed in scope-aggregator with release 4.11

Changed in scope-aggregator:
status: Confirmed → Fix Released
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Fixed in today scope with version 4.11.0 (com.canonical.scopes.dashboard_4.11.0_armhf.click) attached here (and in clicks. note I also added photos scope 4.11.0 to clicks).

When in zh_CN locale, today scope quick start help should NOT display a result for Google.

In any other locale, today scope quick start help SHOULD display a result for Google.

Changed in today-scope:
status: Confirmed → Fix Committed
Changed in photos-scope:
assignee: Kyle Nitzsche (knitzsche) → Penk Chen (penk)
Changed in today-scope:
assignee: Kyle Nitzsche (knitzsche) → Penk Chen (penk)
Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

Hi Penk,

The photos scope and today scope for these new features are attached here and added to clicks branch.

Testing instructions/conditions are explained above for each.

Please arrange QA and release for ota 13.

Thanks!

Revision history for this message
Kyle Nitzsche (knitzsche) wrote :

both today (dashbaord) and photos agg scopes were released in ota13 to fix this.

marking fix-released.

$ bzr ls -r tag:ota13 | grep "\.photos_"
com.canonical.scopes.photos_4.11.0_armhf.click
$ bzr ls -r tag:ota13 | grep dashboard_
com.canonical.scopes.dashboard_4.11.1_armhf.click

Changed in photos-scope:
status: Fix Committed → Fix Released
Changed in today-scope:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.