[telephony] SMS send error checking non existent

[Sergio Schvezov]

SUT: manhattan build 143 on maguro

Steps to reproduce:
- Use a valid working SIM but with no credit
- Open telephony-app
- Go to conversations pane
- Send message to valid number

Expected result:
- Indication of SMS failing to send

Actual result:
- SMS shows as sent, but since there is no credit on the phone it doesn't reach destination

Notes:
I guess this falls into the error checking category

[Ricardo Salveti (rsalveti)]

Mind pasting the output of ofonod from your /var/log/syslog?

Just to see if RIL is actually reporting the error correctly.

[Sergio Schvezov (sergiusens)]

I'm assuming the 'dispatch' call is when it tries to send it and it retries a couple of times until it stops.

[Ricardo Salveti (rsalveti)]

Yeah, the most important is:
Dec 12 13:33:16 localhost ofonod[364]: gril/gril.c:dispatch() RIL Reply: serial-no: 6 errno: GENERIC_FAILURE
Dec 12 13:33:16 localhost ofonod[364]: gril/gril.c:handle_response() comparing req->id: 6 to message->serial_no: 6

So it's indeed failing for RIL, we just need to make sure now that we're pushing this forward to the app via the dbus api from ofono.

[Tony Espy (awe)]

Re-assigned to myself first, as the the error doesn't propagate to the upper ofono SMS layer yet.

[Gustavo Pichorim Boiko (boiko)]

Reassigning back to Tony as this needs to be solved at the ofono level first.

[Tony Espy (awe)]

@Simon

One other SMS feature we currently don't support is receipt of UNSOL_RESPONSE_NEW_SMS_STATUS_REPORT. Perhaps you could investigate this while working on this bug?

[Simon Fels (morphis)]

I have some first implementation for handling the UNSOL_RESPONSE_NEW_SMS_STATUS_REPORT event at https://code.launchpad.net/~morphis/phablet-extras/ofono-lp1089431

To test it we either need a history plugin or use the example/history.c which is compiled into the source with --enable-maintainer-mode

The implementation needs some further testing.

[Simon Fels (morphis)]

I looked through the code related to the original issue of this bug and it seems since the version the bug was reported against the code has changed a bit which might have fixed the bug already.

I am still on the way getting a uncharged SIM card to verify the bug with the latest version.

[Simon Fels (morphis)]

After some further analysis and some brute forcing with the setting the error code of the RIL message manually to RIL_E_GENERIC_FAILURE ofono is still doing fine in sending out correct signals to indicate that sending failed:

ofonod[8809]: src/sms.c:tx_finished() tx_finished 0x187ec38
ofonod[8809]: src/sms.c:tx_finished() Max retries reached, giving up
ofonod[8809]: src/sms.c:sms_tx_queue_remove_entry() 0x187ec38
ofonod[8809]: Sending SMS 0B727DD2A7292A2B3FD37B2FB305A7DE52BD0099 failed
ofonod[8809]: Failure Time: 2013-06-24T17:17:51+0000

[SIGNAL] org.ofono.MessageManager.MessageAdded /ril_0 :1.55
('/ril_0/message_A4EBFF2B3BCA4273B71483290740B4A5A605CE5E', {'State': <'pending'>})
[SIGNAL] org.ofono.NetworkRegistration.PropertyChanged /ril_0 :1.55
('Strength', <byte 0x1d>)
[SIGNAL] org.ofono.Message.PropertyChanged /ril_0/message_A4EBFF2B3BCA4273B71483290740B4A5A605CE5E :1.55
('State', <'failed'>)
[SIGNAL] org.ofono.MessageManager.MessageRemoved /ril_0 :1.55
('/ril_0/message_A4EBFF2B3BCA4273B71483290740B4A5A605CE5E',)