--droplet on command line does not work correctly

Bug #277073 reported by Kent Tenney
2
Affects Status Importance Assigned to Milestone
Phatch
Fix Released
High
Stani

Bug Description

ktenney@nalbert:~/src/phatch$ bzr revno
Format <RepositoryFormatKnit1> for file:///home/ktenney/src/phatch/.bzr/ is deprecated - please use 'bzr upgrade' to get better performance
540

ktenney@nalbert:~$ phatch --droplet
Traceback (most recent call last):
  File "/usr/bin/phatch", line 14, in <module>
    main(config_paths, app_file = __file__)
  File "/usr/lib/python2.5/site-packages/phatch/app.py", line 161, in main
    _droplet(app_file,paths,settings)
  File "/usr/lib/python2.5/site-packages/phatch/app.py", line 136, in _droplet
    gui.drop(actionlist=paths[0],paths=paths[1:],settings=settings)
IndexError: list index out of range
ktenney@nalbert:~$

Stani: It should give a warning instead of a traceback and the droplet functionality should work.

Kent Tenney (ktenney)
description: updated
Revision history for this message
Stani (stani) wrote :

Thanks for reporting this bug. Normally you should specify an action list, but that doesn't seem to work as well.

Changed in phatch:
assignee: nobody → stani
importance: Undecided → High
status: New → Confirmed
description: updated
Revision history for this message
Stani (stani) wrote :

If you don't specify a droplet, Phatch will now let you choose a recent action list.

$ bzr diff
=== modified file 'phatch/app.py'
--- phatch/app.py 2008-03-05 00:56:20 +0000
+++ phatch/app.py 2008-11-08 17:22:16 +0000
@@ -158,6 +158,8 @@
         settings['droplet'] = True
         paths.insert(0,'recent')
     if settings['droplet']:
+ if not paths:
+ paths = ['recent']
         _droplet(app_file,paths,settings)
     elif len(paths)>1 or settings['console'] or settings['interactive']:
         _console(paths,settings)

$ bzr commit -m "Fix --droplet command option without action list"
Committing to: /media/16gb/sync/python/phatch/trunk/
modified phatch/app.py
Committed revision 542.

I am unable to push it to bzr on launchpad at the moment. I'll try to fix that asap.

Changed in phatch:
status: Confirmed → In Progress
Revision history for this message
Stani (stani) wrote :

I've uploaded it upstream to launchpad bzr.

Changed in phatch:
status: In Progress → Fix Committed
Stani (stani)
Changed in phatch:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.