phablet-click-test-setup useless when PPAs enabled.

[Robert Bruce Park]

This is an issue I've run into a number of times. Following instructions at [0] I'll install some updated packages for testing from the PPA:

    phablet-test-run -n -p unity8-autopilot unity8

And then, I'll want to run some click tests, so I'll do:

    phablet-click-test-setup --click com.ubuntu.notes

But then I get errors like this:

pull-lp-source: Downloading unity8 version 7.83+14.04.20131108-0ubuntu1
pull-lp-source: Error: Failed to download: https://launchpad.net/ubuntu/+archive/primary/+files/unity8_7.83+14.04.20131108-0ubuntu1.dsc: 404 Not Found
Traceback (most recent call last):
  File "/usr/bin/phablet-click-test-setup", line 224, in <module>
    main()
  File "/usr/bin/phablet-click-test-setup", line 212, in main
    fetch_test_base(adb, test_dir)
  File "/usr/bin/phablet-click-test-setup", line 186, in fetch_test_base
    get_source_package_tests(package['source'], version, test_dir)
  File "/usr/bin/phablet-click-test-setup", line 149, in get_source_package_tests
    check_call(['pull-lp-source', package, version], cwd=tmp_dir)
  File "/usr/lib/python2.7/subprocess.py", line 540, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['pull-lp-source', 'unity8', '7.83+14.04.20131108-0ubuntu1']' returned non-zero exit status 1

It's easy to see what's going on: phablet-click-test-setup doesn't understand PPAs, and makes the assumption that if a package is installed, it must be available in the archive. So it checks the local installed version and then attempts to download that from the archive, where it can't find it because it's installed from the PPA.

phablet-click-test-setup should get smarter about looking for PPAs to find packages in, because as it currently stands, i'm not able to run any click tests on my device, at least not without reflashing after installing PPA packages.

[0] https://wiki.ubuntu.com/Touch/Testing

[Sergio Schvezov (sergiusens)]

From the start this was designed to not work on r/w images where it is impossible to have PPAs, for which I'm lowering the priority.