changing the shortcuts for previous/next sequence

Bug #506541 reported by Matthieu Bizien on 2010-01-12
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
perroquet
Medium
Fred Bertolus

Bug Description

it's not easy in all keyboards maps to us the page up/page down buttons. I suggest to change them to Up/Down; it's fast because our hands are in the next/prev buttons.

gui.py
class Gui:
    def on_typeView_key_press_event(self,widget, event):
        keyname = gtk.gdk.keyval_name(event.keyval)
        elif keyname == "Down":
            self.core.PreviousSequence()
        elif keyname == "Up":
            self.core.NextSequence()

Fred Bertolus (fred-bertolus) wrote :

It's commited. Thanks. It also fix a navigation regression introduced in developpement version using Up and Down.

Changed in perroquet:
milestone: none → 1.1.0
milestone: 1.1.0 → 1.0.1
assignee: nobody → Fred Bertolus (fred-bertolus)
importance: Undecided → Medium
status: New → Fix Committed
Matthieu Bizien (oao2005) wrote :

I think it would be cleaner to have

        elif keyname == "Page_Up" or keyname == "Up" :
            self.core.NextSequence()

than
        elif keyname == "Page_Down":
            self.core.PreviousSequence()
        elif keyname == "Page_Up":
            self.core.NextSequence()
        elif keyname == "Down":
           self.core.PreviousSequence()
        elif keyname == "Up":
            self.core.NextSequence()

Fred Bertolus (fred-bertolus) wrote :

Too late for 1.0.1, release process is started.

Changed in perroquet:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers