Validity of build/debian/patches

[Raghavendra D Prabhu]

The patches under build/debian/ have been there from 5.5 tree onwards. Need to check if they are still valid for 5.6 (especially the ones for sql files), and others. (Also, check if they are obsolete for 5.5).

Also, contrary to the location, the patches also touch non-build,
non-init scripts (mysql_system_tables_data.sql being one of
them).

[Valerii Kravchuk (valerii-kravchuk)]

The fact that mysql_system_tables_data.sql is mentioned is easy to confirm:

openxs@ao756:~/bzr/percona-5.5$ bzr version-info
revision-id: <email address hidden>
date: 2013-12-13 17:15:43 +0200
build-date: 2013-12-14 13:54:15 +0200
revno: 606
branch-nick: percona-5.5
openxs@ao756:~/bzr/percona-5.5$ grep -rn mysql_system_tables_data.sql build/debian/*
build/debian/patches/50_mysql-test__db_test.dpatch:17: mtr_appendfile_to_file("$sql_dir/mysql_system_tables_data.sql",
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:13:--- a/scripts/mysql_system_tables_data.sql
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:14:+++ b/scripts/mysql_system_tables_data.sql

openxs@ao756:~/bzr/percona-5.6$ grep -rn mysql_system_tables_data.sql build/debian/*
build/debian/patches/50_mysql-test__db_test.dpatch:17: mtr_appendfile_to_file("$sql_dir/mysql_system_tables_data.sql",
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:13:--- a/scripts/mysql_system_tables_data.sql
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:14:+++ b/scripts/mysql_system_tables_data.sql
openxs@ao756:~/bzr/percona-5.6$
openxs@ao756:~/bzr/percona-5.6$ bzr version-info
revision-id: <email address hidden>
date: 2013-12-13 17:26:59 +0200
build-date: 2013-12-14 13:52:26 +0200
revno: 513
branch-nick: percona-5.6

[Laurynas Biveinis (laurynas-biveinis)]

Stewart, can you look into this as a part of your current distro packaging work?

[Raghavendra D Prabhu (raghavendra-prabhu)]

One more thing, since these patches are applied only to debs that we distribute and not to binaries or centos ones (even though some of them may applicable for them too), it creates inconsistentency among the builds distributed.

[Valerii Kravchuk (valerii-kravchuk)]

Same for XtraDB Cluster:

openxs@ao756:~/bzr/percona-xtradb-cluster$ bzr version-info
revision-id: <email address hidden>
date: 2013-12-17 13:20:30 +0530
build-date: 2013-12-18 15:41:25 +0200
revno: 594
branch-nick: percona-xtradb-cluster
openxs@ao756:~/bzr/percona-xtradb-cluster$ grep -rn mysql_system_tables_data.sql build/debian/*
build/debian/patches/50_mysql-test__db_test.dpatch:17: mtr_appendfile_to_file("$sql_dir/mysql_system_tables_data.sql",
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:13:--- a/scripts/mysql_system_tables_data.sql
build/debian/patches/20_scripts__mysql_create_system_tables__no_test.dpatch:14:+++ b/scripts/mysql_system_tables_data.sql

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-1552

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PS-1458