Bad integer comparisons in the "mysqld_safe" script

[Chris Skretowski]

I'm just reporting bug, full credit for fix to vleclere

As per: https://www.percona.com/forums/questions-discussions/percona-xtradb-cluster/49750-can-t-restart-node-after-brutal-shutdown-in-3-nodes-pxc-57-systemd-related?p=49760#post49760

There is a bad integer comparisons in the "mysqld_safe" script.

Code:

What it is:
 if [ $ret > 0 ]; then

What it should be:
 if [ "$ret" -gt "0" ]; then

Bug can be reproduced by following this scenario:

- Start DB, make sure that cluster is in SYNC
- Force brutal shutdown of one node ("power off" or "reset")
- See logs. Without this fix DB will not start.

Thanks
Chris

[Chris Skretowski (coloomb)]

Tested on latest Perocna XtraDB Cluster 5.7 on latest RHEL 7

[EvgeniyPatlan (evgeniy-patlan)]

fix came during merge

[Chris Skretowski (coloomb)]

Thank you for a very quick reaction, perfect!

Id that's released now then this bug can be closed. I guess it will be released to PROD at some point in the future?

Cheers
Chris

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-2024