Debug builds fail

Bug #1384413 reported by Alexey Kopytov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL patches by Codership
Undecided
Unassigned
Percona XtraDB Cluster moved to https://jira.percona.com/projects/PXC
Status tracked in 5.6
5.5
New
Undecided
Unassigned
5.6
Fix Released
Medium
Alexey Kopytov

Bug Description

WITH_DEBUG=1 builds fail with the following compiler errors:

[ 61%] Building CXX object storage/innobase/CMakeFiles/innobase.dir/handler/ha_innodb.cc.o
cc1plus: warnings being treated as errors
/home/user/src/launchpad/pxc/5.6/storage/innobase/handler/ha_innodb.cc: In member function ‘int ha_innobase::wsrep_append_keys(THD*, bool, const uchar*, const uchar*)’:
/home/user/src/launchpad/pxc/5.6/storage/innobase/handler/ha_innodb.cc:10069: error: unused variable ‘key_info’
make[2]: *** [storage/innobase/CMakeFiles/innobase.dir/handler/ha_innodb.cc.o] Error 1
[ 61%] Building CXX object storage/innobase/CMakeFiles/innobase.dir/lock/lock0lock.cc.o
cc1plus: warnings being treated as errors
/home/user/src/launchpad/pxc/5.6/storage/innobase/lock/lock0lock.cc:1809: error: ‘trx_t* lock_rec_other_trx_holds_expl(ulint, trx_id_t, const rec_t*, const buf_block_t*)’ defined but not used
make[2]: *** [storage/innobase/CMakeFiles/innobase.dir/lock/lock0lock.cc.o] Error 1
make[2]: Target `storage/innobase/CMakeFiles/innobase.dir/build' not remade because of e

Verified with 5.6 on CentOS 6.5.

The fix is:

=== modified file 'storage/innobase/handler/ha_innodb.cc'
--- storage/innobase/handler/ha_innodb.cc 2014-10-11 06:46:30 +0000
+++ storage/innobase/handler/ha_innodb.cc 2014-10-22 19:28:02 +0000
@@ -10066,7 +10066,6 @@
   uint len;
   char keyval[WSREP_MAX_SUPPORTED_KEY_LENGTH+1] = {'\0'};
   char *key = &keyval[0];
- KEY *key_info = table->key_info;
   ibool is_null;

   len = wsrep_store_key_val_for_row(

=== modified file 'storage/innobase/lock/lock0lock.cc'
--- storage/innobase/lock/lock0lock.cc 2014-10-11 06:46:30 +0000
+++ storage/innobase/lock/lock0lock.cc 2014-10-22 19:25:56 +0000
@@ -1798,7 +1798,7 @@
  return(trx_id);
 }

-#ifdef UNIV_DEBUG
+#if defined(UNIV_DEBUG) && !defined(WITH_WSREP)
 /*********************************************************************//**
 Checks if some transaction, other than given trx_id, has an explicit
 lock on the given rec, in the given precise_mode.

Related branches

Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXC-1115

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers