Add runtime checks for dynamic variables which are galera incompatible

Bug #1262188 reported by Raghavendra D Prabhu on 2013-12-18
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Percona XtraDB Cluster
Status tracked in 5.6
5.5
Undecided
Unassigned
5.6
Undecided
Unassigned

Bug Description

Need to add runtime checks (in ON_CHECK) at session/global scope for following dynamic (at least some of them are) variables:

binlog_format
locked_in_memory
autoinc_lock_mode
query_cache* (if required)
bind_address (for 127.0.0.1)

Session check for binlog_format was already ported for PXC 5.6
from MDEV-4227.

Confirmed for 5.5 and 5.6:

openxs@ao756:~/bzr/pxc-5.5$ grep -rn "ON_CHECK(bind" *
openxs@ao756:~/bzr/pxc-5.5$ grep -rn "ON_CHECK(query" *
openxs@ao756:~/bzr/pxc-5.5$ grep -rn "ON_CHECK(autoinc" *
openxs@ao756:~/bzr/pxc-5.5$ grep -rn "ON_CHECK(binlog_format" *
Percona-Server/sql/sys_vars.cc:413: NO_MUTEX_GUARD, NOT_IN_BINLOG, ON_CHECK(binlog_format_check),
Percona-XtraDB-Cluster-5.5.34/sql/sys_vars.cc:413: NO_MUTEX_GUARD, NOT_IN_BINLOG, ON_CHECK(binlog_format_check),

Right now required only for binlog_format (and query_cache* if required).

Already committed for binlog_format.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers