Percona XtraDB Cluster - HA scalable solution for MySQL

WSREP check for locks_unsafe_for_binlog is not used

Reported by Raghavendra D Prabhu on 2013-10-15
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
MySQL patches by Codership
Undecided
Unassigned
Percona XtraDB Cluster
Status tracked in Trunk
5.6
Undecided
Unassigned
Trunk
Undecided
Unassigned

Bug Description

In wsrep_check_opts.cc:

=====================================================

    if (slave_threads > 1)
        /* Need to check AUTOINC_LOCK_MODE and LOCKS_UNSAFE_FOR_BINLOG */
    {
        long long autoinc_lock_mode;
        err = get_long_long (opts[AUTOINC_LOCK_MODE], &autoinc_lock_mode, 10);
        if (err) return err;

        bool locks_unsafe_for_binlog;
        err = get_bool (opts[LOCKS_UNSAFE_FOR_BINLOG],&locks_unsafe_for_binlog);
        if (err) return err;

        if (autoinc_lock_mode != 2)
        {
            WSREP_ERROR ("Parallel applying (wsrep_slave_threads > 1) requires"
                         " innodb_autoinc_lock_mode = 2.");
            rcode = EINVAL;
        }
    }

===================================================

Only auto_lock_mode is checked but not locks_unsafe_for_binlog.

Also, this check won't be required in PXC56/codership56 because of:

2013-10-15 20:04:35 7f5e51138740 InnoDB: Warning: Using innodb_locks_unsafe_for_binlog is DEPRECATED. This option may be removed in future releases. Please use READ COMMITTED transaction isolation level instead, see http://dev.mysql.com/doc/refman/5.6/en/set-transaction.html.

Removed that in 5.5 as well since slave threads are executed in READ_COMMITTED and have been for a while.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers